Code quality/combine consecutive issets combine consecutive unsets #31271
Conversation
Codecov Report
@@ Coverage Diff @@
## master #31271 +/- ##
============================================
+ Coverage 62.57% 62.57% +<.01%
- Complexity 18234 18380 +146
============================================
Files 1145 1145
Lines 68397 68390 -7
Branches 1234 1234
============================================
- Hits 42801 42797 -4
+ Misses 25235 25232 -3
Partials 361 361
Continue to review full report at Codecov.
|
| if (isset($_GET['itemType'], $_GET['itemSource'], $_GET['checkReshare'], $_GET['checkShares']) | ||
| ) { |
There was a problem hiding this comment.
maybe to remove the empty lines...
| @@ -110,7 +110,7 @@ public function compare($a, $b) { | |||
| $aa = self::naturalSortChunkify($a); | |||
| $bb = self::naturalSortChunkify($b); | |||
|
|
|||
| for ($x = 0; isset($aa[$x]) && isset($bb[$x]); $x++) { | |||
| for ($x = 0; isset($aa[$x], $bb[$x]) ; $x++) { | |||
There was a problem hiding this comment.
The automagic fixer has left space(s) like here - it looks weird having the ) ;
| @@ -684,7 +684,7 @@ public function __construct($webRoot, \OC\Config $config) { | |||
| 'server' => $_SERVER, | |||
| 'env' => $_ENV, | |||
| 'cookies' => $_COOKIE, | |||
| 'method' => (isset($_SERVER) && isset($_SERVER['REQUEST_METHOD'])) | |||
| 'method' => (isset($_SERVER, $_SERVER['REQUEST_METHOD']) ) | |||
There was a problem hiding this comment.
And it left space between the closing brackets ) )
I suspect that when we add more checks, space in places like that will fail the code quality tests.
|
PHP-CS-Fixer/PHP-CS-Fixer#3339 explains why See PR #31273 for this. |
There was a problem hiding this comment.
@DeepDiver1975 I suggest we merge this, and immediately after merge #31273 which fixes up a bunch of white-space stuff.
That should annoy everyone with an open PR quite enough for 1 day ;)
DeepDiver1975
deleted the
code-quality/combine_consecutive_issets-combine_consecutive_unsets
branch
|
Effective backport is included in #31453 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Adding two additional php--cs-fixer rules
Types of changes
Checklist: