-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable10] owncloud coding standard #31657
Conversation
Codecov Report
@@ Coverage Diff @@
## stable10 #31657 +/- ##
==============================================
- Coverage 62.15% 62.1% -0.06%
+ Complexity 18249 18235 -14
==============================================
Files 1199 1199
Lines 71798 71882 +84
Branches 1248 1248
==============================================
+ Hits 44629 44641 +12
- Misses 26799 26871 +72
Partials 370 370
Continue to review full report at Codecov.
|
c0c583a
to
4a5e1ca
Compare
Conflicting - please merge after 10.0.9 - otherwise we are lost in rebase nightmare again .... |
4a5e1ca
to
e741a24
Compare
Note: For now, this is just a place to keep a handy list of all the commits that make up implementing the code-style checks. The last commit(s) that actually apply the changes to the code can easily be dropped and then re-made by running the checker to make the fixes. That is often easier (and more reliable) than manually resolving loads of "rubbish" conflicts that happen here. |
…rules as defined in .php_cs
e741a24
to
7f59cd4
Compare
Too many conflicts due to objectstore backport merging. It is much quicker to create a new branch, cherry-pick the functional commits and run |
Backport #31442
The first commits backport the various interim php-cs-fixer changes from PR #31198 #31236 #31250 #31271 #31273
That was the easy way to make a list of cherry-picks that all fit nicely on top of each other. And its brings along the
Makefile
and drone changes etc that were already done before #31442The last commit uses
php-cs-fixer
to make the automatic fixes needed for the code instable10