Code quality/psr1 and short array

[DeepDiver1975]

Description

We move on with php-cs-fixer and now enforce PSR1 rule set and the short array syntax rule.

How Has This Been Tested?

• manual local test
• unit tests
• ci

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[phil-davis]

Fails because of the existing phpcs fail that was accidentally merged yesterday. PR #31252 will fix it. Then a rebase here.

[phil-davis]

@ownclouders rebase

[ownclouders]

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

[ownclouders]

Automated rebase with GitMate.io was successful! 🎉

[codecov]

Codecov Report

Merging #31250 into master will decrease coverage by <.01%.
The diff coverage is 50%.

@@             Coverage Diff              @@
##             master   #31250      +/-   ##
============================================
- Coverage     62.57%   62.57%   -0.01%     
- Complexity    18234    18397     +163     
============================================
  Files          1145     1145              
  Lines         68396    68397       +1     
  Branches       1234     1234              
============================================
  Hits          42799    42799              
- Misses        25236    25237       +1     
  Partials        361      361

Flag	Coverage Δ	Complexity Δ
#javascript	52.05% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	63.77% <50%> (-0.01%)	18397 <12> (+163)

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Files/External/LegacyUtil.php	4.06% <ø> (ø)	38 <0> (ø)	⬇️
lib/private/Installer.php	55.7% <ø> (ø)	87 <0> (ø)	⬇️
index.php	0% <0%> (ø)	0 <0> (ø)	⬇️
...private/DB/MySqlSchemaColumnDefinitionListener.php	5.35% <0%> (-0.05%)	46 <0> (ø)
lib/private/legacy/app.php	62.5% <0%> (ø)	187 <0> (ø)	⬇️
lib/private/Preview/Movie.php	0% <0%> (ø)	24 <0> (ø)	⬇️
core/ajax/share.php	0% <0%> (ø)	0 <0> (ø)	⬇️
lib/private/Group/Manager.php	90.16% <100%> (ø)	77 <0> (ø)	⬇️
lib/private/Share20/DefaultShareProvider.php	98.37% <100%> (ø)	114 <0> (ø)	⬇️
lib/private/Files/View.php	84.46% <100%> (ø)	383 <0> (ø)	⬇️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc8a353...cc2eedb. Read the comment docs.

[PVince81]

👍 fine by me

[PVince81]

wait, what about version.php ? the release script might break... remember we tried to change the array syntax a while ago... needs careful testing

[phil-davis]

Effective backport is included in #31453

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.