Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to yarn #29908

Merged
merged 3 commits into from
Jan 8, 2018
Merged

Migrate to yarn #29908

merged 3 commits into from
Jan 8, 2018

Conversation

PVince81
Copy link
Contributor

@PVince81 PVince81 commented Dec 19, 2017 •
edited by DeepDiver1975
Loading

  • TEST: make still works

  • TEST: make dist still works

  • TEST: ownCloud still runs fine

  • Expecting CI failures. Will require npm install -g yarn on CI.

  • build server require yarn

Do we want to backport this ?

@PVince81 PVince81 added this to the development milestone Dec 19, 2017
@PVince81 PVince81 self-assigned this Dec 19, 2017
@PVince81
Copy link
Contributor Author

Fixes #29906

@PVince81
Copy link
Contributor Author

  • dev docs update

@PVince81 PVince81 mentioned this pull request Dec 19, 2017
Closed
@DeepDiver1975
Copy link
Member

  • yarn is installed on jenkins

@DeepDiver1975 DeepDiver1975 force-pushed the move-to-yarn branch 2 times, most recently from 2753ac7 to 850d129 Compare December 20, 2017 10:41
@codecov
Copy link

codecov bot commented Dec 20, 2017 •
edited
Loading

Codecov Report

Merging #29908 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #29908   +/-   ##
=========================================
  Coverage     58.18%   58.18%           
  Complexity    18459    18459           
=========================================
  Files          1092     1092           
  Lines         63620    63620           
=========================================
  Hits          37015    37015           
  Misses        26605    26605

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87eb916...775b526. Read the comment docs.

tboerger
tboerger reviewed Dec 20, 2017
View reviewed changes
tests/drone/yarn-install.sh Outdated
@@ -6,4 +6,5 @@ if [[ "$(pwd)" == "$(cd "$(dirname "$0")"; pwd -P)" ]]; then
exit 1
fi

exec npm install --prefix build
cd build
exec yarn install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe exec yarn install --modules-folder build/node_modules won't require any dir change like before with npm?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried that - did not work out

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, I noticed that yarn doesn't have the --prefix argument but also doesn't complain if you use it... see makefile

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn install --cwd build

@PVince81
Copy link
Contributor Author

👍 for @DeepDiver1975's changes.

Need review for mine.

@felixheidecke if you're familiar with yarn you could check them 😄

@DeepDiver1975 DeepDiver1975 merged commit c42a6a0 into master Jan 8, 2018
@DeepDiver1975 DeepDiver1975 deleted the move-to-yarn branch January 8, 2018 07:32
@DeepDiver1975 DeepDiver1975 mentioned this pull request Jan 8, 2018
Merged
@ownclouders ownclouders mentioned this pull request Jun 13, 2018
Closed
This was referenced Jun 27, 2018
Closed
Closed
@ownclouders ownclouders mentioned this pull request Nov 26, 2018
Closed
@lock
Copy link

lock bot commented Aug 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tboerger tboerger tboerger left review comments

@DeepDiver1975 DeepDiver1975 DeepDiver1975 approved these changes

@felixheidecke felixheidecke Awaiting requested review from felixheidecke

Assignees

@PVince81 PVince81

Labels
3 - To Review
Projects
None yet
Milestone
10.0.5
Development

Successfully merging this pull request may close these issues.
4 participants
@PVince81 @DeepDiver1975 @tboerger @ownclouders