Migrate away from bower workaround to npm

[PVince81]

A few releases ago we moved away from the bower file and moved the dependencies into the build/package.json file for npm. However they still use the "@bower_components" approach which is designed to be transitional. Many automation tools have trouble with these.

We should finish the transition to full npm dependencies and find a way to package said dependencies, maybe with webpack.

Some work had already started in the first commits of #30166 but we got stuck due to weird issues with select2, possibly related to loading order.

Estimate: 2-3md as we need to debug and understand the weird issue and also hope there aren't more such issues.

@DeepDiver1975 @felixheidecke

[patrickjahns]

@PVince81 - please include devops in the process ( with the eye of release automation )

[ownclouders]

GitMate.io thinks possibly related issues are #26863 (Use npm instead of bower), #8545 (password workaround), #29906 (Move from bower to yarn), #30026 (Migrate to yarn), and #29908 (Migrate to yarn).

[DeepDiver1975]

let me throw this POC back into the arena: #30088

[DeepDiver1975]

@PVince81 reopen & rebase to see how far we get?

[DeepDiver1975]

rebased and conflicts resolved - lets see what we want/can reuse

[PVince81]

@felixheidecke offered to help. We need to solve the dependency order issue, see #30088 (comment)

One idea is to locally do a manual concat with grunt and see if we observe the same result. If yes it would confirm that the problem is related to loading order and not something else.

[felixheidecke]

@PVince81 @DeepDiver1975 I found a couple of duplicates such as:

"@bower_components/jcrop": "tapmodo/Jcrop#0.9.12",
"@bower_components/Jcrop": "tapmodo/Jcrop#2.0.4",
"@bower_components/Snap.js": "jakiestfu/Snap.js#1.9.3",
"@bower_components/snapjs": "jakiestfu/Snap.js#2.0.0-rc1",

As well as two libs that do (essentially) the same thing:

"@bower_components/strengthify": "MorrisJobke/strengthify#0.5.2",
"@bower_components/zxcvbn": "dropbox/zxcvbn#4.4.2"

Since strengthify doesn't have an npm package, and no package.json file (can't reference the git path either) I'll drop it.

I' sticking to the latest version in its major release present in the package file.

[PVince81]

@felixheidecke are you working on the actual package.json or the updated one ? Our bundling problem is on this PR #30088 where I believe we already removed duplicate dependencies.

zxcvbn is the database used for strengthify.

[felixheidecke]

I'm working on the actual package also pulling from the other PR.

[DeepDiver1975]

Please only work on the PR as references above

[felixheidecke]

Please only work on the PR as references above

@DeepDiver1975 I tried a different approach using grunt.js instead of webpack because it gives us more control as it simply concatenates files in the desired order. Also works on CSS files as well as modules and CSS found in core. I recommend that approach over webpack.

[PVince81]

whatever you do it won't help with the problem at hand

the problem is that there is a forced update of jquery.ui from 1.10.0 to 1.10.4 and this is what breaks it.

so this is blocked by #18739

or we could spend some time fixing jquery-ui-fixes.css to work with 1.10.4... but I don't think it's worth it if it's just for the bundling part

[PVince81]

backlog for now, blocked by jquery.ui update/removal

[PVince81]

jquery.ui updates still in progress... and still blocked

[DeepDiver1975]

we will not invest more into this -> close