-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce uikit (retry) #30166
Introduce uikit (retry) #30166
Conversation
remaining TODOs:
|
@@ -0,0 +1,44 @@ | |||
var $ = require('jquery'); | |||
window.jQuery = $; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are all those libs bound to the window object instead of some OCL(ib) class? Not sure if this is the right approach 🤔 … am I missing the point here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a hack that @DeepDiver1975 used to make those libs available in the global namespace for backward compatibility as we don't have time to rewrite all the OC JS code to use import statements for those.
See #30088 and comment there if you have a better approach
If we go for separate frontend then eventually core will have no frontend code and more so UIKit should only be provided for Phoenix, not core. Also not to be backported to 10.0. However we need to recover all changes from this PR that help solving UIKit conflicts for #30778 |
@felixheidecke I remember you said introducing UIkit is too complicated due to side effects and would resort to manually writing the CSS when porting the Phoenix views to stable10 ? If that's the case we can close this PR |
Japp, closing. |
Note: contains #30088 and will need rebase once the latter is merged.
Supersedes #29815