Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce uikit (retry) #30166

Closed
wants to merge 5 commits into from
Closed

Introduce uikit (retry) #30166

wants to merge 5 commits into from

Conversation

PVince81
Copy link
Contributor

Note: contains #30088 and will need rebase once the latter is merged.

Supersedes #29815

@PVince81 PVince81 added this to the development milestone Jan 16, 2018
@PVince81 PVince81 mentioned this pull request Jan 16, 2018
5 tasks
@PVince81
Copy link
Contributor Author

remaining TODOs:

  • Fix core styling to not be destroyed by uikit side-effects
  • Provide mechanism to compile and load any uikit theme from theme app (idea: OC_Defaults::getMainCss() to load the theme's uikit CSS instead of the default one)
  • if theme app enabled, don't load the UIKit owncloud.css (or is there a way to override)
  • future: think of a way to make it easy for apps to compile and deploy their uikit less file to css

@@ -0,0 +1,44 @@
var $ = require('jquery');
window.jQuery = $;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are all those libs bound to the window object instead of some OCL(ib) class? Not sure if this is the right approach 🤔 … am I missing the point here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a hack that @DeepDiver1975 used to make those libs available in the global namespace for backward compatibility as we don't have time to rewrite all the OC JS code to use import statements for those.

See #30088 and comment there if you have a better approach

@PVince81
Copy link
Contributor Author

If we go for separate frontend then eventually core will have no frontend code and more so UIKit should only be provided for Phoenix, not core.

Also not to be backported to 10.0.

However we need to recover all changes from this PR that help solving UIKit conflicts for #30778

@PVince81 PVince81 changed the title Introduce uikit 2 Introduce uikit (retry) Mar 14, 2018
@felixboehm felixboehm modified the milestones: development, planned Apr 10, 2018
@felixboehm felixboehm added the v11 label Apr 24, 2018
@PVince81
Copy link
Contributor Author

@felixheidecke I remember you said introducing UIkit is too complicated due to side effects and would resort to manually writing the CSS when porting the Phoenix views to stable10 ? If that's the case we can close this PR

@felixheidecke
Copy link
Contributor

Japp, closing.

@felixheidecke felixheidecke deleted the introduce-uikit-2 branch April 26, 2018 08:19
@PVince81 PVince81 modified the milestones: development, QA Jun 13, 2018
@phil-davis phil-davis removed the v11 label Mar 18, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants