Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn search broken under bmake #31742

Closed
mqudsi opened this issue Jun 13, 2018 · 4 comments
Closed

yarn search broken under bmake #31742

mqudsi opened this issue Jun 13, 2018 · 4 comments

Comments

@mqudsi
Copy link

mqudsi commented Jun 13, 2018

Steps to reproduce

  1. Use FreeBSD
  2. cd core; make

Expected behaviour

yarn (available in PATH) should be found.

Actual behaviour

mqudsi@freebsd /u/l/w/owncloud> make
Building core

Note: You can type 'make help' for more targets

yarn is not available on your system, please install yarn (npm install -g yarn)
*** Error code 1

Server configuration

Operating system: FreeBSD 11.1

Web server:
nginx n/a

Database:
n/a

PHP version:
n/a

ownCloud version: (see ownCloud admin page)
master

Updated from an older ownCloud or fresh install:
fresh install

Where did you install ownCloud from:
git

Signing status (ownCloud 9.0 and above):
n/a

The issue is that the Makefile script uses syntax specific to GNU make (the $(shell ...)) syntax. Under FreeBSD, YARN != command -v yarn .... should be used instead.

Alternatively, a "bridge" makefile can be used for make commands to be executed under gmake transparently (if installed), allowing GNU make syntax to be used freely if cross-compatible makefile scripts are not a project goal or priority: https://github.com/neosmart/gmake-proxy

@ownclouders
Copy link
Contributor

GitMate.io thinks possibly related issues are #13402 (... broken), #29908 (Migrate to yarn), #30026 (Migrate to yarn), #18512 (Master broken), and #17404 (About search).

@DeepDiver1975
Copy link
Member

We mainly target GNU linux. So from my pov the makefiles are okay.
If you'd like to work on making them cross-compatible feel free to open up pull requests in order to fix this.
If not nothing will happen in this area because freebsd is not a target development platform for us.

@PVince81 PVince81 added this to the maybe some day milestone Jun 13, 2018
@ownclouders
Copy link
Contributor

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.)

@lock
Copy link

lock bot commented Jul 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants