fix: closes all connections when stopped #41
Conversation
This fix closes all connections when the Hapi server is stopped. Otherwise the node process will continue running until the last connection was closed.
There was a problem hiding this comment.
The travis ci build failed. Please check travis log there are some code format issues (missing semi-colons and so on) plus you'll need to add some tests to cover the new code you added. The coverage was at 100% on last build and usually there is a 100% coverage on all module in HapiJS org.
|
Yep, will tackle this tomorrow. Just wanted to get a feeling first if any PR is welcome since the latest welcome is quite old 😊 |
|
Thanks for your contribution. PR are always welcomed 😉. However I'm not the lead maintainer on this project. I intervened because there were some more work required to make the PR mergeable but in the end @geek will have the final word when it comes to accept or not the contribution. |
jaulz
force-pushed
the
patch-1
branch
5 times, most recently
from
e52cbf2
to
055e0f5
Compare
|
@Nargonath @geek I created tests for the new feature but in Node.js v11 some strange things happen with the experimental microtask queue. any idea how we could fix this or if we can ignore this in the meantime? |
|
I think there is a problem with Node 11 at the moment. Perhaps @geek just need to disable the Node 11 job for now as it's been done in hapijs/nes#257. |
|
Great, thanks! Looking forward for @geek feedback 😊 |
|
@jaulz I'll update master to use different node versions on travis. Thanks for the fix. |
This fix closes all connections when the Hapi server is stopped. Otherwise the node process will continue running until the last connection was closed.