Merge pull request #41 from jaulz/patch-1

fix: closes all connections when stopped

lib/index.js

@@ -3,6 +3,7 @@
 // Load modules
 
 const Net = require('net');
+const Util = require('util');
 const Repl = require('repl');
 const Barrier = require('cb-barrier');
 const Hoek = require('hoek');
@@ -56,6 +57,35 @@ exports.register = async function (server, options) {
         barrier.pass();
     });
 
+    // Keep track of all connections
+    const sockets = [];
+    tcp.on('connection', (socket) => {
+
+        sockets.push(socket);
+        socket.once('close', () => {
+
+            sockets.splice(sockets.indexOf(socket), 1);
+        });
+    });
+
+    // Close all connections when Hapi server is stopped
+    server.ext({
+        type: 'onPostStop',
+        method: async () => {
+
+            // Close server (which keeps existing connections)
+            Util.promisify(tcp.close.bind(tcp))();
+
+            // Close all sockets
+            await Promise.all(sockets.map((socket) => {
+
+                return Util.promisify(socket.end.bind(socket))('\n', 'utf8');
+            }));
+
+            return null;
+        }
+    });
+
     tcp.listen(settings.port);
     await barrier;
 };

test/index.js

@@ -443,3 +443,45 @@ it('allows the use of extra repl start options', async () => {
 
     return barrier;
 });
+
+it('closes all connections when the server is stopped', async () => {
+
+    const barrier = new Barrier();
+    const server = Hapi.server();
+    const port = await internals.availablePort();
+
+    await server.register({ plugin: Reptile, options: { port } });
+
+    const address = Net.Socket.prototype.address;
+    Net.Socket.prototype.address = function () {
+
+        Net.Socket.prototype.address = address;
+        return {
+            family: 'IPv4',
+            address: '127.0.0.1'
+        };
+    };
+    const sock = Net.connect(port);
+    let state = 0;
+
+    sock.once('close', () => {
+
+        barrier.pass();
+    });
+
+    sock.on('readable', () => {
+
+        const buffer = sock.read();
+        if (!buffer) {
+            return;
+        }
+
+        if (state === 0) {
+            server.stop();
+        }
+
+        state++;
+    });
+
+    return barrier;
+});