Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Missing pyproject.toml Deps, Breaking Release PyPi Workflow & Add Build Wheel / SDist Check to PR Workflow #938

Merged
merged 3 commits into from
Jun 2, 2024

Conversation

lapp0
Copy link
Collaborator

@lapp0 lapp0 commented Jun 1, 2024

Fixes #934

Problem

  • Release to PyPi failed for v0.0.42 because pycountry and pyairports wasn't in pyproject.toml required dependencies
  • We merged code which caused this failure without detecting it.

Solution

  • Add pycountry and pyairports to pyproject.toml required dependencies
  • Add Test SDist and Build Wheel to PR Test Suite

Example: failing workflow without pycountry and pyairports

Example: Release to PyPi using new workflow, works up to the point it 403s. I expect it to release provided a correct pypi token, but I can smoke test first if you prefer.

@lapp0 lapp0 changed the title Fix Missing Dependencies in Release PyPi Workflow & Add Build Wheel / SDist Check to PR Worklflow Fix Missing Dependencies in Release PyPi Workflow & Add Build Wheel / SDist Check to PR Workflow Jun 1, 2024
@lapp0 lapp0 changed the title Fix Missing Dependencies in Release PyPi Workflow & Add Build Wheel / SDist Check to PR Workflow Fix Missing pyproject.toml Deps, Breaking Release PyPi Workflow & Add Build Wheel / SDist Check to PR Workflow Jun 1, 2024
@rlouf rlouf merged commit 95f108e into outlines-dev:main Jun 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix PyPi deployment workflow - missing pycountry and pyairports
2 participants