Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PyPi deployment workflow - missing pycountry and pyairports #934

Closed
lapp0 opened this issue May 31, 2024 · 0 comments · Fixed by #938
Closed

Fix PyPi deployment workflow - missing pycountry and pyairports #934

lapp0 opened this issue May 31, 2024 · 0 comments · Fixed by #938
Labels

Comments

@lapp0
Copy link
Collaborator

lapp0 commented May 31, 2024

Describe the issue as clearly as possible:

PyPi deployment workflow failed for v0.0.42.

https://github.com/outlines-dev/outlines/actions/runs/8922899171/job/24505995524

Steps/code to reproduce the bug:

Run pypi release workflow.

Expected result:

successful deployment

Error message:

ImportError: The `airports` module requires "pyairports" to be installed. You can install it with "pip install pyairports"

Outlines/Python version information:

Version information

``` (command output here) ```

Context for the issue:

    1. We need to add pyairports and pycountry to pyproject.toml.
    1. As part of our PR CI/CD, we should run the PyPi workflow, but exclude the push to PyPi step.
@lapp0 lapp0 added the bug label May 31, 2024
@lapp0 lapp0 changed the title Fix PyPi deployment Fix PyPi deployment workflow - missing pycountry and pyairports May 31, 2024
@rlouf rlouf closed this as completed in #938 Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
1 participant