Force dates, uuid, datetimes, times to be between quotes #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlouf
force-pushed
the
njahromi/fix-string-fromat-quotes
branch
from
516d7a8
to
b79c81a
Compare
rlouf
force-pushed
the
njahromi/fix-string-fromat-quotes
branch
from
f11c4b4
to
31cb24f
Compare
|
nice! thank you for the quick turnaround. Do you know when we can expect a release to pick up this fix? |
|
Just cut a new release, should be available in a few minutes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #814. @navster888 I was unable to push minor fixes to your branch so I am opening this one. All I did was fixing the formatting issues, and add tests that would have failed with the previous version of the regular expression.
Closes #828.