Fix string format quotes #814
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rlouf apologies for the delay was out of town this week. Still have not been able to get a working dev setup locally, however given this change seems simple I'm wondering if we can rely on the checks in CI. Either way I believe this PR is ready for review. Will give local setup another go once I'm back home tomorrow and see if I can figure things out in the meantime, cheers. |
|
I updated the code in #831 and merged. Thank you for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The string format regexes setup in #567 were not properly wrapped in quotes, resulting in invalid jsons being produced.
Updating the DATE_TIME, DATE, TIME, and UUID regexes to properly include
"wrapping the values.TODO: Adding additional tests that verify the produced regex is able to parse nested values, which is how this bug was originally noticed. Will revisit later this afternoon, struggling to get my python environment configured correctly in order to run tests locally.