Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Support self-hosted GitLab instances where base URL has a path component #3819

Merged
merged 15 commits into from
Jan 31, 2024
Merged

🐛 Support self-hosted GitLab instances where base URL has a path component #3819

merged 15 commits into from
Jan 31, 2024

Commits on Dec 28, 2023

  1. Add GL_HOST env flag 

    Self-hosted instances which dont use a subdomain result in broken API links.
This change may not be finished, but is intended to evaluate the solution.

Previously, self hosted instances where the instance is part of the path (foo.com/gitlab/owner/repo)
would have their API base URL registered as foo.com/api/v4/ instead of foo.com/gitlab/api/v4/

Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    22bc273 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. include token in gitlab project probe 

    Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    4741438 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. consider GL_HOST when parsing gitlab repo urls 

    Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    22d788c View commit details
    Browse the repository at this point in the history

  2. remove unneeded GL_HOST parsing 

    now that repoURL_parse handles GL_HOST, we dont need it elsewhere.

Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    d3d5ba6 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Merge branch 'main' into fix/gitlab-host-path 

    Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    62a45fd View commit details
    Browse the repository at this point in the history

  2. cleanup 

    Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    25efa2d View commit details
    Browse the repository at this point in the history

  3. mention GL_HOST in readme 

    Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    5de9997 View commit details
    Browse the repository at this point in the history

  4. fix linter 

    Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    ea0cfa4 View commit details
    Browse the repository at this point in the history

  5. handle GL_HOST without scheme 

    Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    fb20f8b View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Merge branch 'main' into fix/gitlab-host-path 

    Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    8f15aef View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. move api-less check earlier 

    if we can avoid an API call, do it.

Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    2b2ea9d View commit details
    Browse the repository at this point in the history

  2. try listing projects with and without auth token 

    Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    54f8493 View commit details
    Browse the repository at this point in the history

  3. fix linter 

    Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    be834eb View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. revert passing token to list projects 

    the simpler the better

Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    426eca0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix/gitlab-host-path 

    Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    693712c View commit details
    Browse the repository at this point in the history