🐛 Support self-hosted GitLab instances where base URL has a path component #3819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Self-hosted instances which dont use a subdomain result in broken API links. This change may not be finished, but is intended to evaluate the solution. Previously, self hosted instances where the instance is part of the path (foo.com/gitlab/owner/repo) would have their API base URL registered as foo.com/api/v4/ instead of foo.com/gitlab/api/v4/ Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
now that repoURL_parse handles GL_HOST, we dont need it elsewhere. Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3819 +/- ##
==========================================
- Coverage 75.54% 70.75% -4.80%
==========================================
Files 232 232
Lines 15772 15784 +12
==========================================
- Hits 11915 11168 -747
- Misses 3121 3930 +809
+ Partials 736 686 -50 |
|
@mwager mind testing this? And seeing if the README instructions are clear enough? |
|
Confirming that this works and scorecard successfully displays the results:
README instructions looking good to me! |
spencerschrock
requested review from
raghavkaul and
laurentsimon
and removed request for
a team
Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
commented
Jan 29, 2024
if we can avoid an API call, do it. Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
|
I tested on the latest commit:
Works like before. Doing the curl command without the auth header returns 200 with json data...
|
Signed-off-by: Spencer Schrock <sschrock@google.com>
the simpler the better Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
I've reverted one part to keep the PR smaller. if this causes it to fail for you, i will revert the reversion and merge the current state. |
|
Tested again on commit 693712c, everything fine :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bug fix
What is the current behavior?
Assumes the gitlab API base url doesn't have any part after the domain.
What is the new behavior (if this is a feature change)?**
Adds a new environment variable,
GL_HOSTto handle these situations.The env var is needed, otherwise there's ambiguity over what part of the URL is part of the API url, the repo owner, or project.
Which issue(s) this PR fixes
Fixes #3696
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)