Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable IMU orientation output #966

Merged
merged 5 commits into from
Oct 25, 2021
Merged

Disable IMU orientation output #966

merged 5 commits into from
Oct 25, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jul 2, 2021

Signed-off-by: Ian Chen ichen@osrfoundation.org

Depends on:

Updates the imu system to disable publishing orientation data.

  • Update: an <enable_orientation>0</enable_orientation> SDF element is now added to individual models.. We will also need to update all the robot models on fuel.

With this change, the orientation values in the ROS imu msg should now be zeros, and the first element of the orientation_covariance field is set to -1 as per ROS imu msg documentation.

To test, launch any world with a UAV robot, e.g.:

ign launch -v 4 competition.ign worldName:=simple_cave_01 circuit:=cave robotName1:=X4 robotConfig1:=X4_SENSOR_CONFIG_1

and echo the imu msg to see that the orientation is now zeros:

rostopic echo /X4/imu/data

Example output:

header: 
  seq: 12506
  stamp: 
    secs: 50
    nsecs:  32000000
  frame_id: "X1/base_link/imu_sensor"
orientation: 
  x: 0.0
  y: 0.0
  z: 0.0
  w: 0.0
orientation_covariance: [-1.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0]
angular_velocity: 
  x: 0.000139300054549
  y: 5.63009660877e-05
  z: -0.000108313959937
angular_velocity_covariance: [0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0]
linear_acceleration: 
  x: -0.0891951904981
  y: -0.0936655693381
  z: 9.87060748913
linear_acceleration_covariance: [0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0]

@iche033 iche033 requested a review from mjcarroll July 2, 2021 00:14
@m3d
Copy link
Contributor

m3d commented Jul 2, 2021

What is this PR about?! (2 days after closing qualification??) Does it mean the we will not get IMU orientation data anymore???!

@zbynekwinkler
Copy link

Isn't it past feature freeze time as described on https://github.com/osrf/subt/wiki front page, which is set to "May 25 - September 24"?

@angelacmaio angelacmaio changed the base branch from final_event to master July 2, 2021 14:30
@nkoenig
Copy link
Contributor

nkoenig commented Jul 2, 2021

This is targeting the master branch, not the final_event branch. This code is not going to effect SubT finals.

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@nkoenig nkoenig merged commit 79d3283 into master Oct 25, 2021
@peci1
Copy link
Collaborator

peci1 commented Oct 26, 2021

Why did this change affect all robots? Most decent IMUs (like the Xsense MTI-30 we use) normally output orientation computed by an internal integrated filter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants