Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdformat9, gazebo11: use tinyxml1 #2526

Merged
merged 9 commits into from
Jan 8, 2024
Merged

sdformat9, gazebo11: use tinyxml1 #2526

merged 9 commits into from
Jan 8, 2024

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Jan 7, 2024

Part of #2503 and #2505. Depend on a brew extracted formula instead of homebrew/core/tinyxml in preparation for the removal of tinyxml from homebrew-core.

@scpeters
Copy link
Member Author

scpeters commented Jan 7, 2024

build bottle

@scpeters scpeters merged commit b110766 into master Jan 8, 2024
1 check passed
@scpeters scpeters deleted the scpeters/use_tinyxml1 branch January 8, 2024 22:13
@okalachev
Copy link

I guess, after this change I started to periodically get an error when installing gazebo11:

Error: Cannot install osrf/simulation/tinyxml1 because conflicting formulae are installed.
==> Installing osrf/simulation/gazebo11 dependency: osrf/simulation/tinyxml1
  tinyxml: because differing version of the same formula

See the log: https://github.com/okalachev/flix/actions/runs/7514522280/job/20457487348#step:3:661.

@okalachev
Copy link

okalachev commented Jan 17, 2024

@scpeters, the problem still occurs :(

@scpeters
Copy link
Member Author

what happens if you brew remove tinyxml? There are only a few formulae left that use tinyxml, so in most cases it should be possible to remove tinyxml in favor of tinyxml1

@okalachev
Copy link

@scpeters, tinyxml is not installed.

It gets installed during brew install gazebo11 for some reason: https://github.com/okalachev/flix/actions/runs/7560949053/job/20588083848#step:3:8

So brew install gazebo11 on a clean macOS doesn't work.

@okalachev
Copy link

okalachev commented Jan 17, 2024

Update, this error is gone, after I added brew update before installation of Gazebo, but now I fell into another error with 2to3 package installation...

@scpeters
Copy link
Member Author

Update, this error is gone, after I added brew update before installation of Gazebo, but now I fell into another error with 2to3 package installation...

that sounds like actions/setup-python#577

we use the following to workaround it:

https://github.com/gazebosim/sdformat/blob/sdf14/.github/workflows/macos.yml#L19-L26

@okalachev
Copy link

@scpeters, it works. Though now Gazebo installs on a clean macOS for 1 hour 18 minutes. I'm not sure if it's normal.

@scpeters
Copy link
Member Author

@scpeters, it works. Though now Gazebo installs on a clean macOS for 1 hour 18 minutes. I'm not sure if it's normal.

a new version of protobuf was recently merged to homebrew-core, which broke our binary bottles, so they are being rebuilt (see #2527). gz-harmonic has been rebuilt already, and the rest should be rebuilt within a few days.

@okalachev
Copy link

@scpeters, thanks, I'll be waiting for that!

@scpeters
Copy link
Member Author

the gazebo11 bottle was rebuilt in #2538

okalachev added a commit to okalachev/flix that referenced this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants