Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Guide #1831

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

feature: Guide #1831

wants to merge 17 commits into from

Conversation

mulfvik
Copy link
Contributor

@mulfvik mulfvik commented Sep 10, 2023

Fix #1019

Config example
{ "name": "guide", "options": { "title": "Guidar dig genom kartan...", "hideButton": { "visible": true } } }
Also see the guide config options in root

@johnnyblasta johnnyblasta changed the title Guide feature: Guide Sep 11, 2023
@mulfvik mulfvik marked this pull request as draft September 11, 2023 09:12
@mulfvik
Copy link
Contributor Author

mulfvik commented Sep 11, 2023

Hi @tonnyandersson, there is still some work to be done on this for the access to the guide.

  • Button in left side tools that has the option to blink when opening the map as it is in the guide to make the user notice?
  • How to handle the splash screen. A button in splash modal that activates the guide and closes the splash?
  • Only having a activation button in menu

Any other ideas?

@mulfvik mulfvik marked this pull request as ready for review September 11, 2023 16:07
@mulfvik mulfvik marked this pull request as draft September 11, 2023 16:16
@jokd
Copy link
Contributor

jokd commented Sep 18, 2023

Looks nice. I would like the guide to be started by the user from the menu, so having it configurable would be great.

@mulfvik mulfvik mentioned this pull request Sep 27, 2023
@mulfvik mulfvik marked this pull request as ready for review March 21, 2024 14:21
@mulfvik
Copy link
Contributor Author

mulfvik commented Apr 9, 2024

@tonnyandersson This is ready for review. I slimmed it down a bit to only be available through a button. Thinking that if it should be started up when initializing the map it can be done from the splash control.

@Flodkvist
Copy link
Contributor

Nice!
This is a good addition.

Some things that could be discussed

Should the guide "be aware" if it´s being used on a large or small screen?

  • The pulsation does not work on collapsed legend when configuration/default is set to be expanded.
    (On small screens the legend is never expanded when map loads?).

  • If using the guide on small screen the position tool is not present and the guide explaining this might be confusing.

To be able to place the activation button in the mapmenu would be nice

  • What it does is more intuitive if combined with a text, like the other functions inside of mapmenu.

  • When using a map with more tools in o-tools-left the space runs out very quickly on a laptop screen.

Could the popup be used for the guide? Might make the map interface more cohesive interface. Also having the dots to show the user the number of steps in the guide would be nice
image

@tonnyandersson
Copy link
Collaborator

tonnyandersson commented Apr 24, 2024

I also suggest using Material Icons instead of Font Awesome as much as possible. In this case, it looks like the FA signpost icon gets clipped. The MI equivalent has a better fit out of the box.

Add logic to show/hide prev/next buttons based on currentIndex in the guide
controls. This ensures that the correct buttons are displayed at all times.
Removed the old guide button and replaced it with a new menu item using the
"ic_routes_24px" icon to open the modal. This change improves the user
experience and aligns with the updated design.
Observers if guide modal is removed from DOM and sets the proper state to guide menu item. If the menu item state is 'initial', it creates a modal and sets the state to 'active'. If the state is 'active', it closes the modal and sets the state back to 'initial'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User manual
4 participants