Use the taproot dust limit when determining whether padding is required. #1929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The alignment output is sent to a taproot address, so it's the taproot dust limit we need to check against, not the dust limit for the type of the destination address.
gmart7t2
force-pushed
the
fix-padding-calculation
branch
from
abd689f
to
ac91ec7
Compare
gmart7t2
force-pushed
the
fix-padding-calculation
branch
2 times, most recently
from
9d6f94f
to
ac91ec7
Compare
raphjaph
approved these changes
Jul 24, 2023
sidmorizon
added a commit
to OneKeyHQ/ord
that referenced
this pull request
Aug 1, 2023
* Add contributing section (ordinals#2261) * Implement clean index shutdown to prevent index corruption (with clippy updates for Rust 1.71) (ordinals#2275) * gracefully shutdown index update thread to prevent index corruption * Use `next_back()` instead of `rev().next()` for rust 1.71 --------- Co-authored-by: victorkirov <victor.kirov@gmail.com> * Modify `ord list` output to include the end of each range (ordinals#1998) * Don't create default data directory if --index overrides it (ordinals#1991) * Fix docs inconsistency (ordinals#2276) * Fix ordering for reinscriptions and show all reinscriptions for sat (ordinals#2279) * Add satpoint and address to index export (ordinals#2284) * Update bitcoin dependencies (ordinals#2281) * Update redb (ordinals#2294) * Add retry to fetcher (ordinals#2297) * Clean up deploy scripts (ordinals#2298) * Fix justfile recipe (ordinals#2299) * Release 0.8.1 (ordinals#2300) * Add `amount` field to `wallet inscriptions` output. (ordinals#1928) * Fix dust limit for padding in `TransactionBuilder` (ordinals#1929) * Inform user when redb starts in recovery mode (ordinals#2304) * Fix remote RPC wallet commands (ordinals#1766) * Select multiple utxos (ordinals#2303) Co-authored-by: Greg Martin <gm7t2@gmail.com> * feat: add outputs api --------- Co-authored-by: raph <raphjaph@protonmail.com> Co-authored-by: victorkirov <victor.kirov@gmail.com> Co-authored-by: gmart7t2 <49558347+gmart7t2@users.noreply.github.com> Co-authored-by: ordinally <11798624+veryordinally@users.noreply.github.com> Co-authored-by: Carlos Alaniz <carlosglvn93@gmail.com> Co-authored-by: Greg Martin <gm7t2@gmail.com>
Raylin51
pushed a commit
to 0xaklabs/ord
that referenced
this pull request
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The alignment output is sent to a taproot address, so it's the taproot dust limit we need to check against, not the dust limit for the type of the destination address.
The existing code fails if you try to send to a non-taproot bech32 address (dust limit 294) with a satpoint offset anywhere from 294 to 329 because the check for whether to create an alignment output uses the 294 dust limit but the invariant uses 330: