Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "amount" field to "wallet inscriptions" output. #1928

Merged

Conversation

gmart7t2
Copy link
Contributor

Allow people to check the postage on each of their inscriptions.

@gmart7t2
Copy link
Contributor Author

The lint failures go away after #1923.

@rot13maxi
Copy link
Contributor

this is always going to be 10000 until we have an option to change the output postage amount, or am I missing something?

@gmart7t2 gmart7t2 force-pushed the show-postage-in-wallet-inscriptions branch from 06d2411 to df88698 Compare April 12, 2023 14:50
@raphjaph
Copy link
Collaborator

When sending around inscriptions the postage will decrease over time. It will only be replenished if it would go below the dust limit. So this change makes sense.

@gmart7t2 gmart7t2 force-pushed the show-postage-in-wallet-inscriptions branch 2 times, most recently from 7a04d5d to df88698 Compare April 14, 2023 22:02
Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing with Casey. This is missing a few things that he will address in his review.

casey
casey previously requested changes Apr 19, 2023
Copy link
Collaborator

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is a good addition.

This requires a test! We should have an integration test that the returned postage field is correct. Add one in tests/wallet/inscriptions.rs.

src/subcommand/wallet/inscriptions.rs Outdated Show resolved Hide resolved
src/subcommand/wallet/inscriptions.rs Outdated Show resolved Hide resolved
src/subcommand/wallet/inscriptions.rs Outdated Show resolved Hide resolved
@aguinaldok4 aguinaldok4 linked an issue May 29, 2023 that may be closed by this pull request
@raphjaph raphjaph dismissed casey’s stale review July 24, 2023 20:38

changes implemented

@raphjaph raphjaph self-requested a review July 24, 2023 20:43
@raphjaph raphjaph enabled auto-merge (squash) July 24, 2023 20:45
@raphjaph raphjaph merged commit 9c16801 into ordinals:master Jul 24, 2023
6 checks passed
sidmorizon added a commit to OneKeyHQ/ord that referenced this pull request Aug 1, 2023
* Add contributing section (ordinals#2261)

* Implement clean index shutdown to prevent index corruption (with clippy updates for Rust 1.71) (ordinals#2275)

* gracefully shutdown index update thread to prevent index corruption

* Use `next_back()` instead of `rev().next()` for rust 1.71

---------

Co-authored-by: victorkirov <victor.kirov@gmail.com>

* Modify `ord list` output to include the end of each range (ordinals#1998)

* Don't create default data directory if --index overrides it (ordinals#1991)

* Fix docs inconsistency (ordinals#2276)

* Fix ordering for reinscriptions and show all reinscriptions for sat (ordinals#2279)

* Add satpoint and address to index export (ordinals#2284)

* Update bitcoin dependencies (ordinals#2281)

* Update redb (ordinals#2294)

* Add retry to fetcher (ordinals#2297)

* Clean up deploy scripts (ordinals#2298)

* Fix justfile recipe (ordinals#2299)

* Release 0.8.1 (ordinals#2300)

* Add `amount` field to `wallet inscriptions` output. (ordinals#1928)

* Fix dust limit for padding in `TransactionBuilder` (ordinals#1929)

* Inform user when redb starts in recovery mode (ordinals#2304)

* Fix remote RPC wallet commands (ordinals#1766)

* Select multiple utxos (ordinals#2303)

Co-authored-by: Greg Martin <gm7t2@gmail.com>

* feat: add outputs api

---------

Co-authored-by: raph <raphjaph@protonmail.com>
Co-authored-by: victorkirov <victor.kirov@gmail.com>
Co-authored-by: gmart7t2 <49558347+gmart7t2@users.noreply.github.com>
Co-authored-by: ordinally <11798624+veryordinally@users.noreply.github.com>
Co-authored-by: Carlos Alaniz <carlosglvn93@gmail.com>
Co-authored-by: Greg Martin <gm7t2@gmail.com>
Raylin51 pushed a commit to 0xaklabs/ord that referenced this pull request Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

https://status.twitterstat.us/pages/564314ae3309c22c3b0002fa/rss
4 participants