Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adguardhome: enable legacy openssl provider for nodejs and bump to 0.107.25 #20611

Merged
merged 2 commits into from
Mar 8, 2023
Merged

adguardhome: enable legacy openssl provider for nodejs and bump to 0.107.25 #20611

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0f9b83
adguardhome: enable legacy openssl provider for nodejs
dobo90 Mar 8, 2023
8eddbae
adguardhome: bump to 0.107.25
dobo90 Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions net/adguardhome/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ include $(TOPDIR)/rules.mk

PKG_NAME:=adguardhome
PKG_VERSION:=0.107.24
PKG_RELEASE:=1
PKG_RELEASE:=2

PKG_SOURCE_PROTO:=git
PKG_SOURCE_VERSION:=v$(PKG_VERSION)
Expand Down Expand Up @@ -56,7 +56,7 @@ endef
define Build/Compile
( \
pushd $(PKG_BUILD_DIR) ; \
make js-deps js-build ; \
NODE_OPTIONS=--openssl-legacy-provider make js-deps js-build ; \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

export NODE_OPTIONS=--openssl-legacy-provider ; \
make js-deps js-build ; \

I see they recommend this writing style, and it works.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no difference in this case.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make it look more comfortable...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just a personal preference. tbh I don't like making local variables global.

popd ; \
$(call GoPackage/Build/Compile) ; \
)
Expand Down