adguardhome: enable legacy openssl provider for nodejs and bump to 0.107.25 #20611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently compilation fails because of: ``` opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ], library: 'digital envelope routines', reason: 'unsupported', code: 'ERR_OSSL_EVP_UNSUPPORTED' ``` What's interesting package gets built but when trying to access UI there's `404: page not found` error. It has been reported in multiple places: * AdguardTeam/AdGuardHome#5559 * AdguardTeam/AdGuardHome#4595 Signed-off-by: Dobroslaw Kijowski <dobo90@gmail.com>
* Full changelog available at: * https://github.com/AdguardTeam/AdGuardHome/releases/tag/v0.107.25 Signed-off-by: Dobroslaw Kijowski <dobo90@gmail.com>
PussAzuki
reviewed
Mar 8, 2023
| @@ -56,7 +56,7 @@ endef | |||
| define Build/Compile | |||
| ( \ | |||
| pushd $(PKG_BUILD_DIR) ; \ | |||
| make js-deps js-build ; \ | |||
| NODE_OPTIONS=--openssl-legacy-provider make js-deps js-build ; \ | |||
There was a problem hiding this comment.
export NODE_OPTIONS=--openssl-legacy-provider ; \
make js-deps js-build ; \
I see they recommend this writing style, and it works.
There was a problem hiding this comment.
There's no difference in this case.
There was a problem hiding this comment.
Just to make it look more comfortable...
There was a problem hiding this comment.
It's just a personal preference. tbh I don't like making local variables global.
|
404 fixed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: me
Compile tested: aarch64_generic, NanoPi R2S, OpenWrt SNAPSHOT r22247
Run tested: aarch64_generic, NanoPi R2S, OpenWrt SNAPSHOT r22247
Description:
adguardhome: enable legacy openssl provider for nodejs
Currently compilation fails because of:
What's interesting package gets built but when trying to access UI there's
404: page not founderror.It has been reported in multiple places:
adguardhome: bump to 0.107.25