Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix media contents error in arrow format #986

Merged

Conversation

cih9088
Copy link
Contributor

@cih9088 cih9088 commented May 4, 2023

Summary

  • Fixed to initialize Image media from bytes not a decoded numpy array
  • Fixed not to save PointCloud when save_media=False

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Inhyuk Andy Cho andy.inhyuk.jo@intel.com

@cih9088 cih9088 added the BUG Something isn't working label May 4, 2023
@cih9088 cih9088 added this to the 1.3.0 milestone May 4, 2023
@cih9088 cih9088 requested review from a team as code owners May 4, 2023 00:09
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
@codecov-commenter
Copy link

codecov-commenter commented May 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03 ⚠️

Comparison is base (320ea82) 78.70% compared to head (64aa4b2) 78.67%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           releases/1.2.0     #986      +/-   ##
==================================================
- Coverage           78.70%   78.67%   -0.03%     
==================================================
  Files                 231      231              
  Lines               26425    26421       -4     
  Branches             5260     5263       +3     
==================================================
- Hits                20797    20787      -10     
- Misses               4401     4408       +7     
+ Partials             1227     1226       -1     
Flag Coverage Δ
macos-11_Python-3.8 77.69% <100.00%> (-0.03%) ⬇️
ubuntu-20.04_Python-3.8 78.64% <100.00%> (-0.03%) ⬇️
windows-2019_Python-3.8 78.55% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/components/media.py 79.01% <100.00%> (-0.07%) ⬇️
...atumaro/plugins/data_formats/arrow/mapper/media.py 73.79% <100.00%> (-2.25%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you change the target branch of this PR to releases/1.2.0?

@cih9088 cih9088 changed the base branch from develop to releases/1.2.0 May 4, 2023 01:04
@cih9088 cih9088 force-pushed the fix/arrow-media-bytes branch 2 times, most recently from b0607c8 to 2002928 Compare May 4, 2023 01:18
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
@cih9088 cih9088 modified the milestones: 1.3.0, 1.2.0 May 4, 2023
Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cih9088 cih9088 merged commit b4d5d7e into openvinotoolkit:releases/1.2.0 May 4, 2023
@cih9088 cih9088 deleted the fix/arrow-media-bytes branch May 4, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants