Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bytes property bug #978

Merged
merged 4 commits into from
Apr 27, 2023
Merged

Conversation

cih9088
Copy link
Contributor

@cih9088 cih9088 commented Apr 26, 2023

Summary

Fixed returning None if function is given to data

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@cih9088 cih9088 added the BUG Something isn't working label Apr 26, 2023
@cih9088 cih9088 added this to the 1.3.0 milestone Apr 26, 2023
@cih9088 cih9088 requested review from a team as code owners April 26, 2023 01:53
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (ce714d2) 78.70% compared to head (9bd8d3c) 78.71%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #978      +/-   ##
===========================================
+ Coverage    78.70%   78.71%   +0.01%     
===========================================
  Files          231      231              
  Lines        26454    26452       -2     
  Branches      5261     5260       -1     
===========================================
+ Hits         20820    20823       +3     
+ Misses        4407     4404       -3     
+ Partials      1227     1225       -2     
Flag Coverage Δ
macos-11_Python-3.8 77.74% <100.00%> (+<0.01%) ⬆️
ubuntu-20.04_Python-3.8 78.69% <100.00%> (-0.01%) ⬇️
windows-2019_Python-3.8 78.60% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/components/media.py 79.01% <100.00%> (-0.07%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

vinnamkim
vinnamkim previously approved these changes Apr 26, 2023
Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cih9088 and others added 4 commits April 27, 2023 12:21
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Co-authored-by: Vinnam Kim <vinnam.kim@gmail.com>
wonjuleee
wonjuleee previously approved these changes Apr 27, 2023
@cih9088 cih9088 merged commit e620b26 into openvinotoolkit:develop Apr 27, 2023
@cih9088 cih9088 deleted the fix/bytes-bug branch April 27, 2023 05:15
cih9088 added a commit to cih9088/datumaro that referenced this pull request May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants