-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add full encryption/decryption functionalities for image datasets to DatumaroBinary format #831
Add full encryption/decryption functionalities for image datasets to DatumaroBinary format #831
Conversation
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
- Refactor CommonSemanticSegmentation unit tests as well Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
- Support DatasetItem by Datumaro binary format but annotations are not yet. Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
…maro-binary-format-dataset-item Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
- Import yolo -> export DatumaroBinary (encryption) -> import DatumaroBinary (encryption) -> Export yolo Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
4fc561e
to
95dcb4b
Compare
…datumaro-binary Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
95dcb4b
to
8d23d28
Compare
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #831 +/- ##
===========================================
- Coverage 78.53% 78.49% -0.04%
===========================================
Files 205 206 +1
Lines 24832 24939 +107
Branches 5004 5007 +3
===========================================
+ Hits 19502 19577 +75
- Misses 4208 4236 +28
- Partials 1122 1126 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please hold this until reviewing cryptography-related security tasks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The codes look great to me.
But, let's do below in the future
- separate an option for media encryption
- reduce the encryption/decryption overhead
- provide jupyter notebook or cli tutorial for the practical usage of data encryption
…datumaro-binary Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
I made tickets to resolve your concerns:
|
Summary
DatumaroBinary
format.Crypter
todatumaro/components
Crypter
is given.backward_dict()
.How to test
I added unit tests and an integration test for this feature.
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.