-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop DatumaroBinaryFormat to export/import the dataset header & DatasetItem #828
Develop DatumaroBinaryFormat to export/import the dataset header & DatasetItem #828
Conversation
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
- Refactor CommonSemanticSegmentation unit tests as well Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
- Support DatasetItem by Datumaro binary format but annotations are not yet. Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some duplicates from previous PRs. Could you separate them first?
…maro-binary-format-dataset-item Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
It's ready for review now. |
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Codecov ReportBase: 78.33% // Head: 78.47% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #828 +/- ##
===========================================
+ Coverage 78.33% 78.47% +0.14%
===========================================
Files 189 191 +2
Lines 23681 23911 +230
Branches 4895 4912 +17
===========================================
+ Hits 18550 18764 +214
- Misses 4032 4044 +12
- Partials 1099 1103 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I added 454b22c because of the recent CI failure: https://github.com/openvinotoolkit/datumaro/actions/runs/4289888756/jobs/7473354523. This is because our datumaro/datumaro/util/test_utils.py Line 353 in 1e6761b
After this time, I think that it would be good to move |
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Summary
DatasetItem
(annotations are not completely finished and the subsequent PR will cover more)How to test
The added tests in this PR cover the changes.
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.