Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DatumaroBinaryFormat to export/import the image dataset completely #829

Merged

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Feb 27, 2023

Summary

  • Ticket no. 104650
  • Finish to implement DatumaroBinaryFormat to export/import the dataset (only w/ Image media for now).

How to test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
 - Refactor CommonSemanticSegmentation unit tests as well

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
 - Support DatasetItem by Datumaro binary format but annotations are not yet.

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim added this to the 1.1.0 milestone Feb 27, 2023
@vinnamkim vinnamkim added ENHANCE Enhancement of existing features data formats PR is related to dataset formats labels Feb 27, 2023
@vinnamkim vinnamkim changed the title Feature/add annotation mapper Implement DatumaroBinaryFormat to export/import the image dataset completely Feb 27, 2023
@vinnamkim vinnamkim force-pushed the feature/add-annotation-mapper branch 2 times, most recently from d89710d to dbb7e6b Compare February 27, 2023 06:02
…maro-binary-format-dataset-item

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim marked this pull request as ready for review March 1, 2023 07:52
…tation-mapper

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2023

Codecov Report

Patch coverage: 96.44% and project coverage change: +0.01 🎉

Comparison is base (ca79fbd) 78.47% compared to head (2070b95) 78.48%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #829      +/-   ##
===========================================
+ Coverage    78.47%   78.48%   +0.01%     
===========================================
  Files          191      196       +5     
  Lines        23911    24304     +393     
  Branches      4912     4946      +34     
===========================================
+ Hits         18765    19076     +311     
- Misses        4044     4127      +83     
+ Partials      1102     1101       -1     
Flag Coverage Δ
macos-11_Python-3.8 77.82% <96.44%> (+0.02%) ⬆️
ubuntu-20.04_Python-3.8 78.46% <96.44%> (+<0.01%) ⬆️
windows-2019_Python-3.8 78.41% <97.12%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/util/__init__.py 86.73% <40.00%> (-2.63%) ⬇️
...ata_formats/datumaro_binary/mapper/dataset_item.py 81.03% <81.03%> (ø)
datumaro/components/annotation.py 91.52% <94.73%> (+0.03%) ⬆️
datumaro/components/format_detection.py 93.14% <100.00%> (+0.16%) ⬆️
datumaro/components/media.py 83.42% <100.00%> (ø)
datumaro/components/operations.py 83.68% <100.00%> (+0.02%) ⬆️
...o/plugins/data_formats/datumaro_binary/__init__.py 100.00% <100.00%> (ø)
...umaro/plugins/data_formats/datumaro_binary/base.py 96.15% <100.00%> (+0.80%) ⬆️
...o/plugins/data_formats/datumaro_binary/exporter.py 97.46% <100.00%> (+1.38%) ⬆️
...o/plugins/data_formats/datumaro_binary/importer.py 100.00% <100.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@sooahleex sooahleex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good for me, except Mapper classes. I understood the concept of it, but I could not catch up deeply for Mapper classes, so this should be covered through others reviews.

Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please hold this when finalizing the discussion about encryption.

@wonjuleee wonjuleee merged commit 6b613c7 into openvinotoolkit:develop Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data formats PR is related to dataset formats ENHANCE Enhancement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants