Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TileTransform documentation and Jupyter notebook example #794

Merged

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Jan 16, 2023

Summary

  • Add TileTransform documentation and Jupyter notebook example
  • Fix a bug when doing transform by Dataset.transform(TileTransform, ...) function.

How to test

  • I updated the existing test to cover the bug.

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

 - Because of the recent refactoring for data_format plugins

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim marked this pull request as ready for review January 19, 2023 07:29
@vinnamkim vinnamkim changed the title Feature/tile documentation Add TileTransform documentation and Jupter notebook example Jan 19, 2023
@vinnamkim vinnamkim changed the title Add TileTransform documentation and Jupter notebook example Add TileTransform documentation and Jupyter notebook example Jan 19, 2023
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2023

Codecov Report

Base: 83.95% // Head: 83.93% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (36edac1) compared to base (da67b52).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #794      +/-   ##
===========================================
- Coverage    83.95%   83.93%   -0.02%     
===========================================
  Files          173      173              
  Lines        22779    22783       +4     
  Branches      4951     4951              
===========================================
  Hits         19124    19124              
- Misses        2535     2538       +3     
- Partials      1120     1121       +1     
Flag Coverage Δ
macos-11_Python-3.10 83.86% <50.00%> (-0.02%) ⬇️
macos-11_Python-3.7 83.54% <50.00%> (-0.02%) ⬇️
macos-11_Python-3.8 83.78% <50.00%> (-0.02%) ⬇️
macos-11_Python-3.9 ?
ubuntu-20.04_Python-3.10 83.86% <50.00%> (-0.02%) ⬇️
ubuntu-20.04_Python-3.7 83.54% <50.00%> (-0.02%) ⬇️
ubuntu-20.04_Python-3.8 83.79% <50.00%> (-0.02%) ⬇️
ubuntu-20.04_Python-3.9 83.80% <50.00%> (-0.02%) ⬇️
windows-2019_Python-3.10 83.82% <50.00%> (-0.02%) ⬇️
windows-2019_Python-3.7 83.50% <50.00%> (-0.02%) ⬇️
windows-2019_Python-3.8 83.74% <50.00%> (-0.02%) ⬇️
windows-2019_Python-3.9 83.76% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/components/media.py 85.09% <25.00%> (-0.76%) ⬇️
datumaro/plugins/tiling/tile.py 94.06% <100.00%> (ø)
datumaro/plugins/splitter.py 88.47% <0.00%> (-0.23%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vinnamkim vinnamkim added BUG Something isn't working DOC Improvements or additions to documentation labels Jan 19, 2023
datumaro/plugins/tiling/tile.py Outdated Show resolved Hide resolved
datumaro/plugins/tiling/tile.py Outdated Show resolved Hide resolved
tests/test_tiling.py Outdated Show resolved Hide resolved
datumaro/components/media.py Show resolved Hide resolved
 - Also fix author name

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim mentioned this pull request Jan 19, 2023
7 tasks
Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! thanks.

@wonjuleee wonjuleee merged commit f4c8e3c into openvinotoolkit:develop Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working DOC Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants