Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MergeTileTransform #796

Merged
merged 21 commits into from
Jan 27, 2023
Merged

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Jan 19, 2023

Signed-off-by: Kim, Vinnam vinnam.kim@intel.com

Summary

How to test

Compare equivalence between the source dataset and the Tile -> MergeTile transformed dataset.

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

 - Because of the recent refactoring for data_format plugins

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
 - Also fix author name

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@openvinotoolkit openvinotoolkit deleted a comment from review-notebook-app bot Jan 25, 2023
@vinnamkim vinnamkim marked this pull request as ready for review January 25, 2023 04:49
@vinnamkim vinnamkim added the ENHANCE Enhancement of existing features label Jan 25, 2023
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2023

Codecov Report

Base: 83.90% // Head: 84.01% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (7742d84) compared to base (f4c8e3c).
Patch coverage: 92.65% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #796      +/-   ##
===========================================
+ Coverage    83.90%   84.01%   +0.10%     
===========================================
  Files          173      174       +1     
  Lines        22783    22956     +173     
  Branches      4951     4985      +34     
===========================================
+ Hits         19117    19286     +169     
+ Misses        2550     2546       -4     
- Partials      1116     1124       +8     
Flag Coverage Δ
macos-11_Python-3.10 83.92% <92.65%> (+0.06%) ⬆️
macos-11_Python-3.7 83.61% <92.61%> (?)
macos-11_Python-3.8 83.85% <92.65%> (+0.06%) ⬆️
macos-11_Python-3.9 83.85% <92.65%> (+0.05%) ⬆️
ubuntu-20.04_Python-3.10 83.93% <92.65%> (+0.06%) ⬆️
ubuntu-20.04_Python-3.7 83.62% <92.61%> (?)
ubuntu-20.04_Python-3.8 83.86% <92.65%> (+0.06%) ⬆️
ubuntu-20.04_Python-3.9 83.88% <92.65%> (+0.06%) ⬆️
windows-2019_Python-3.10 83.89% <92.65%> (+0.06%) ⬆️
windows-2019_Python-3.7 83.57% <92.61%> (?)
windows-2019_Python-3.8 83.81% <92.65%> (+0.06%) ⬆️
windows-2019_Python-3.9 83.81% <92.65%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/components/annotation.py 91.62% <80.00%> (-0.61%) ⬇️
datumaro/components/media.py 84.91% <81.25%> (-0.19%) ⬇️
datumaro/plugins/tiling/merge_tile.py 95.74% <95.74%> (ø)
datumaro/plugins/splitter.py 88.47% <0.00%> (-0.23%) ⬇️
datumaro/util/os_util.py 77.27% <0.00%> (+7.57%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@@ -1,2 +1,3 @@
dvc>=2.7.0
fsspec <= 2022.11.0; python_version < '3.8' # https://github.com/openvinotoolkit/datumaro/actions/runs/4003215621/jobs/6871114851#step:5:1647
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for? As far as I know, adding dependency just before releases is definitely not preferred. @yunchu, Could you add the comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the recent CI failure https://github.com/openvinotoolkit/datumaro/actions/runs/4003215621/jobs/6871114851#step:5:1647.
dvc requires fsspec but fsspec is recently updated to 2023.1.0 from 2022.11.0 (https://pypi.org/project/fsspec/#history).
However, fsspec==2023.1.0 tries to import from fsspec.asyn import fsspec_loop which is Python built-in module but not existed in Python=3.7.
Therefore, it is inevitable to downgrade fsspec for Python=3.7.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

datumaro/plugins/tiling/untile.py Show resolved Hide resolved
datumaro/plugins/tiling/merge_tile.py Show resolved Hide resolved
datumaro/plugins/tiling/merge_tile.py Show resolved Hide resolved
datumaro/plugins/tiling/merge_tile.py Show resolved Hide resolved
datumaro/plugins/tiling/merge_tile.py Show resolved Hide resolved
datumaro/plugins/tiling/merge_tile.py Show resolved Hide resolved
datumaro/plugins/tiling/merge_tile.py Show resolved Hide resolved
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinnamkim vinnamkim merged commit e7c674d into openvinotoolkit:develop Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENHANCE Enhancement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants