-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MergeTileTransform #796
Conversation
- Because of the recent refactoring for data_format plugins Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
- Also fix author name Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Codecov ReportBase: 83.90% // Head: 84.01% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #796 +/- ##
===========================================
+ Coverage 83.90% 84.01% +0.10%
===========================================
Files 173 174 +1
Lines 22783 22956 +173
Branches 4951 4985 +34
===========================================
+ Hits 19117 19286 +169
+ Misses 2550 2546 -4
- Partials 1116 1124 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@@ -1,2 +1,3 @@ | |||
dvc>=2.7.0 | |||
fsspec <= 2022.11.0; python_version < '3.8' # https://github.com/openvinotoolkit/datumaro/actions/runs/4003215621/jobs/6871114851#step:5:1647 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this for? As far as I know, adding dependency just before releases is definitely not preferred. @yunchu, Could you add the comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the recent CI failure https://github.com/openvinotoolkit/datumaro/actions/runs/4003215621/jobs/6871114851#step:5:1647.
dvc
requires fsspec
but fsspec
is recently updated to 2023.1.0
from 2022.11.0
(https://pypi.org/project/fsspec/#history).
However, fsspec==2023.1.0
tries to import from fsspec.asyn import fsspec_loop
which is Python built-in module but not existed in Python=3.7.
Therefore, it is inevitable to downgrade fsspec
for Python=3.7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Kim, Vinnam vinnam.kim@intel.com
Summary
MergeTile
transformHow to test
Compare equivalence between the source dataset and the
Tile
->MergeTile
transformed dataset.Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.