Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto-documentation for the data_format plugins #793

Merged

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Jan 16, 2023

Signed-off-by: Kim, Vinnam vinnam.kim@intel.com

Summary

  • Because of the recent refactoring for data_format plugins, auto documentation from Python code has been failed for those files affected by the previous refactoring work. Please refer to this page.
  • This PR fixes it.

How to test

Before fix After fix
image image

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

 - Because of the recent refactoring for data_format plugins

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@openvinotoolkit openvinotoolkit deleted a comment from review-notebook-app bot Jan 16, 2023
@vinnamkim vinnamkim added BUG Something isn't working DOC Improvements or additions to documentation labels Jan 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2023

Codecov Report

Base: 83.92% // Head: 83.92% // No change to project coverage 👍

Coverage data is based on head (f91bb78) compared to base (98ae851).
Patch has no changes to coverable lines.

❗ Current head f91bb78 differs from pull request most recent head 662b069. Consider uploading reports for the commit 662b069 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #793   +/-   ##
========================================
  Coverage    83.92%   83.92%           
========================================
  Files          173      173           
  Lines        22739    22739           
  Branches      4946     4946           
========================================
  Hits         19084    19084           
  Misses        2535     2535           
  Partials      1120     1120           
Flag Coverage Δ
macos-11_Python-3.10 ?
macos-11_Python-3.7 83.52% <ø> (ø)
macos-11_Python-3.8 83.77% <ø> (ø)
macos-11_Python-3.9 83.77% <ø> (-0.01%) ⬇️
ubuntu-20.04_Python-3.10 83.84% <ø> (ø)
ubuntu-20.04_Python-3.7 83.53% <ø> (ø)
ubuntu-20.04_Python-3.8 83.77% <ø> (+<0.01%) ⬆️
ubuntu-20.04_Python-3.9 83.78% <ø> (ø)
windows-2019_Python-3.10 83.81% <ø> (+<0.01%) ⬆️
windows-2019_Python-3.7 83.49% <ø> (ø)
windows-2019_Python-3.8 83.72% <ø> (ø)
windows-2019_Python-3.9 83.74% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for fixing this!

@vinnamkim vinnamkim merged commit da67b52 into openvinotoolkit:develop Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working DOC Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants