imagenet_txt_format: implement automatic category creation #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiltsov-max
reviewed
Oct 5, 2021
zhiltsov-max
reviewed
Oct 5, 2021
zhiltsov-max
reviewed
Oct 5, 2021
zhiltsov-max
reviewed
Oct 5, 2021
7 tasks
added 2 commits
October 8, 2021 13:01
I implemented this as part of prototyping AC integration. AC is able to load ImageNet without a labels file, and while you can notionally do that with Datumaro by supplying an empty label list, it doesn't work in practice. As soon as Datumaro encounters the first annotation, it fails, since the label ID fails the range check. Solve this by adding an option to automatically create new categories with generic names if an out-of-range label ID is encountered. Also, add a way to specify an empty label list from the command line.
They are mutually exclusive, so we don't really need to have both.
zhiltsov-max
previously approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I implemented this as part of prototyping Accuracy Checker integration. AC is able to load ImageNet without a labels file, and while you can notionally do that with Datumaro by supplying an empty label list, it doesn't work in practice. As soon as Datumaro encounters the first annotation, it fails, since the label ID fails the range check.
Solve this by adding an option to automatically create new categories with generic names if an out-of-range label ID is encountered.
Also, add a way to specify an empty label list from the command line.
How to test
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.