Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import for CelebA dataset format #484

Merged
merged 24 commits into from
Oct 25, 2021
Merged

Import for CelebA dataset format #484

merged 24 commits into from
Oct 25, 2021

Conversation

yasakova-anastasia
Copy link

@yasakova-anastasia yasakova-anastasia commented Oct 1, 2021 •
edited
Loading

Summary

How to test

Unit tests, manually on original dataset

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

IRDonch
IRDonch suggested changes Oct 4, 2021
View reviewed changes
Copy link

@IRDonch IRDonch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only looked at the documentation so far; will review the code later.

site/content/en/docs/formats/celeba.md Outdated Show resolved Hide resolved
site/content/en/docs/formats/celeba.md Outdated Show resolved Hide resolved
site/content/en/docs/formats/celeba.md Outdated Show resolved Hide resolved
site/content/en/docs/formats/celeba.md Outdated Show resolved Hide resolved
site/content/en/docs/formats/celeba.md Outdated Show resolved Hide resolved
site/content/en/docs/user-manual/supported_formats.md Outdated Show resolved Hide resolved
@yasakova-anastasia
Copy link
Author

@IRDonch, I fixed the documentation by your comments.

IRDonch
IRDonch reviewed Oct 5, 2021
View reviewed changes
datumaro/plugins/celeba_format.py Outdated Show resolved Hide resolved
datumaro/plugins/celeba_format.py Outdated Show resolved Hide resolved
datumaro/plugins/celeba_format.py Outdated Show resolved Hide resolved
datumaro/plugins/celeba_format.py Outdated Show resolved Hide resolved
datumaro/plugins/celeba_format.py Outdated Show resolved Hide resolved
datumaro/plugins/celeba_format.py Outdated Show resolved Hide resolved
datumaro/plugins/celeba_format.py Outdated Show resolved Hide resolved
datumaro/plugins/celeba_format.py Outdated Show resolved Hide resolved
datumaro/plugins/celeba_format.py Show resolved Hide resolved
IRDonch
IRDonch reviewed Oct 7, 2021
View reviewed changes
tests/assets/align_celeba_dataset/Anno/identity_CelebA.txt Show resolved Hide resolved
datumaro/plugins/celeba_format.py Outdated Show resolved Hide resolved
datumaro/plugins/celeba_format.py Outdated Show resolved Hide resolved
datumaro/plugins/celeba_format.py Outdated Show resolved Hide resolved
datumaro/plugins/celeba_format.py Outdated Show resolved Hide resolved
@yasakova-anastasia
Copy link
Author

@IRDonch, I fixed.

IRDonch
IRDonch previously approved these changes Oct 7, 2021
View reviewed changes
@IRDonch
Copy link

IRDonch commented Oct 7, 2021

@zhiltsov-max Are you going to review this, or should I just merge it?

@zhiltsov-max zhiltsov-max merged commit 0a279e3 into develop Oct 25, 2021
@zhiltsov-max zhiltsov-max deleted the ay/add-celeba-format branch October 25, 2021 12:26
@yasakova-anastasia yasakova-anastasia mentioned this pull request Dec 2, 2021
Open
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiltsov-max zhiltsov-max zhiltsov-max approved these changes

@IRDonch IRDonch IRDonch left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import for CelebA dataset format
3 participants
@yasakova-anastasia @IRDonch @zhiltsov-max