Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TblStats in Configurable Validator #1504

Merged

Conversation

sooahleex
Copy link
Contributor

@sooahleex sooahleex commented May 22, 2024

Summary

How to test

  • Add unit tests for configurable validator

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT

@sooahleex sooahleex force-pushed the feat/config_validate_tabular branch from 05f3b75 to 43a2305 Compare May 22, 2024 04:40
@sooahleex sooahleex force-pushed the feat/config_validate_tabular branch from 4b9696b to 516cae0 Compare May 22, 2024 05:47
@sooahleex sooahleex force-pushed the feat/config_validate_tabular branch from 516cae0 to 284e1b1 Compare May 22, 2024 06:57
@sooahleex sooahleex marked this pull request as ready for review May 22, 2024 07:09
@sooahleex sooahleex requested review from a team as code owners May 22, 2024 07:09
@sooahleex sooahleex requested review from wonjuleee and removed request for a team May 22, 2024 07:09
Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 92.22798% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 80.88%. Comparing base (44cc56a) to head (cc7d530).
Report is 60 commits behind head on develop.

Files Patch % Lines
src/datumaro/plugins/configurable_validator.py 92.22% 4 Missing and 11 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1504      +/-   ##
===========================================
+ Coverage    80.85%   80.88%   +0.02%     
===========================================
  Files          271      276       +5     
  Lines        30689    31862    +1173     
  Branches      6197     6442     +245     
===========================================
+ Hits         24815    25770     +955     
- Misses        4489     4664     +175     
- Partials      1385     1428      +43     
Flag Coverage Δ
ubuntu-20.04_Python-3.10 80.87% <92.22%> (+0.02%) ⬆️
windows-2022_Python-3.10 80.85% <92.22%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sooahleex sooahleex merged commit c27e919 into openvinotoolkit:develop May 23, 2024
8 checks passed
@sooahleex sooahleex added this to the 1.8.0 milestone Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants