Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TabularValidator #1498

Merged
merged 17 commits into from
May 22, 2024
Merged

Conversation

sooahleex
Copy link
Contributor

@sooahleex sooahleex commented May 13, 2024

Summary

  • Add TabularValidator
  • Validate annotations based on dataset after AstypeAnnotations
  • Validation result consists of
    • defined_labels
    • empty_labels : which label is not set for item(= nan label)
    • defined_captions
    • empty_captions : which caption is not set for item (= nan caption)
    • redundancies
    • total_ann_count
    • items_missing_annotations : if item does not any annotations
    • items_broken_annotations
  • Anomaly type consists of
    • MissingAnnotation : if item did not have any caption or label
    • BrokenAnnotations
    • FewSamplesInLabel
    • ImbalancedLabels
    • EmptyLabel : If value is Nan for a label
    • FewSamplesInCaption
    • RedundanciesInCaption
    • EmptyCaption : If value is Nan for a caption
    • ImbalancedCaptions : There is an imbalance in the caption distribution
    • ImbalancedDistInCaptions : Values are not evenly distributed for a caption only if caption is number
    • FarFromCaptionMean : An annotation has ann too small or large value than average for a caption only if caption is number
  • Updating ConfigurableValidator will be covered following PR

How to test

  • Add unit test for TabularValidator

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT

@sooahleex sooahleex marked this pull request as ready for review May 16, 2024 08:47
@sooahleex sooahleex requested review from a team as code owners May 16, 2024 08:47
@sooahleex sooahleex requested review from vinnamkim and removed request for a team May 16, 2024 08:47
@sooahleex sooahleex marked this pull request as draft May 16, 2024 09:15
@sooahleex sooahleex marked this pull request as ready for review May 16, 2024 09:52
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 95.17685% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 80.79%. Comparing base (44cc56a) to head (23ebb8b).
Report is 59 commits behind head on develop.

Files Patch % Lines
src/datumaro/plugins/validators.py 95.81% 3 Missing and 8 partials ⚠️
src/datumaro/components/errors.py 91.30% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1498      +/-   ##
===========================================
- Coverage    80.85%   80.79%   -0.07%     
===========================================
  Files          271      276       +5     
  Lines        30689    31680     +991     
  Branches      6197     6391     +194     
===========================================
+ Hits         24815    25597     +782     
- Misses        4489     4664     +175     
- Partials      1385     1419      +34     
Flag Coverage Δ
ubuntu-20.04_Python-3.10 80.78% <95.17%> (-0.06%) ⬇️
windows-2022_Python-3.10 80.77% <95.17%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sooahleex sooahleex merged commit 5573852 into openvinotoolkit:develop May 22, 2024
8 checks passed
@sooahleex sooahleex added this to the 1.8.0 milestone Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants