Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix errata in voc doc #1163

Merged

Conversation

jihyeonyi
Copy link
Contributor

@jihyeonyi jihyeonyi commented Oct 5, 2023

Summary

Color values in the labelmap.txt should be separated by commas, not colons.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@jihyeonyi jihyeonyi added the DOC Improvements or additions to documentation label Oct 5, 2023
@jihyeonyi jihyeonyi added this to the 1.5.1 milestone Oct 5, 2023
@jihyeonyi jihyeonyi marked this pull request as ready for review October 5, 2023 04:29
@jihyeonyi jihyeonyi requested review from a team as code owners October 5, 2023 04:29
@jihyeonyi jihyeonyi requested review from sooahleex and removed request for a team October 5, 2023 04:29
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (45958aa) 79.96% compared to head (dd70117) 79.96%.

Additional details and impacted files
@@               Coverage Diff               @@
##           releases/1.5.0    #1163   +/-   ##
===============================================
  Coverage           79.96%   79.96%           
===============================================
  Files                 267      267           
  Lines               29981    29981           
  Branches             5898     5898           
===============================================
  Hits                23975    23975           
  Misses               4649     4649           
  Partials             1357     1357           
Flag Coverage Δ
macos-11_Python-3.8 79.08% <ø> (ø)
ubuntu-20.04_Python-3.8 79.95% <ø> (ø)
windows-2019_Python-3.8 79.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jihyeonyi jihyeonyi merged commit f476dec into openvinotoolkit:releases/1.5.0 Oct 5, 2023
9 checks passed
@vinnamkim vinnamkim mentioned this pull request Oct 6, 2023
6 tasks
yunchu pushed a commit to yunchu/datumaro that referenced this pull request Oct 23, 2023
<!-- Contributing guide:
https://github.com/openvinotoolkit/datumaro/blob/develop/CONTRIBUTING.md
-->

### Summary
Color values in the labelmap.txt should be separated by commas, not
colons.

<!--
Resolves openvinotoolkit#111 and openvinotoolkit#222.
Depends on openvinotoolkit#1000 (for series of dependent commits).

This PR introduces this capability to make the project better in this
and that.

- Added this feature
- Removed that feature
- Fixed the problem openvinotoolkit#1234
-->

### How to test
<!-- Describe the testing procedure for reviewers, if changes are
not fully covered by unit tests or manual testing can be complicated.
-->

### Checklist
<!-- Put an 'x' in all the boxes that apply -->
- [ ] I have added unit tests to cover my changes.​
- [ ] I have added integration tests to cover my changes.​
- [x] I have added the description of my changes into
[CHANGELOG](https://github.com/openvinotoolkit/datumaro/blob/develop/CHANGELOG.md).​
- [x] I have updated the
[documentation](https://github.com/openvinotoolkit/datumaro/tree/develop/docs)
accordingly

### License

- [ ] I submit _my code changes_ under the same [MIT
License](https://github.com/openvinotoolkit/datumaro/blob/develop/LICENSE)
that covers the project.
  Feel free to contact the maintainers if that's a concern.
- [ ] I have updated the license header for each file (see an example
below).

```python
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DOC Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants