Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc links for 1.5.1 #1165

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Oct 6, 2023

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@vinnamkim vinnamkim added this to the 1.5.1 milestone Oct 6, 2023
@vinnamkim vinnamkim added BUG Something isn't working DOC Improvements or additions to documentation labels Oct 6, 2023
@vinnamkim vinnamkim marked this pull request as ready for review October 6, 2023 05:06
@vinnamkim vinnamkim requested review from a team as code owners October 6, 2023 05:06
@vinnamkim vinnamkim requested review from wonjuleee and removed request for a team October 6, 2023 05:06
smidm and others added 2 commits October 6, 2023 14:07
fix link to transforms.py to match changed directory structure
- Fixed broken YOLO-ultralytics links that were referring to the format
specifications on GitHub. The source files were apparently changed, thus
links became invalid.
@vinnamkim vinnamkim changed the title Fix doc links for 1.5.0 Fix doc links for 1.5.1 Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c02ed68) 79.96% compared to head (ce46c55) 79.96%.

Additional details and impacted files
@@               Coverage Diff               @@
##           releases/1.5.0    #1165   +/-   ##
===============================================
  Coverage           79.96%   79.96%           
===============================================
  Files                 267      267           
  Lines               29981    29981           
  Branches             5898     5898           
===============================================
  Hits                23975    23975           
  Misses               4649     4649           
  Partials             1357     1357           
Flag Coverage Δ
macos-11_Python-3.8 79.08% <ø> (ø)
ubuntu-20.04_Python-3.8 79.95% <ø> (ø)
windows-2019_Python-3.8 79.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -14,6 +14,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Bug fixes
- Fix errata in the voc document. Color values in the labelmap.txt should be separated by commas, not colons.
(<https://github.com/openvinotoolkit/datumaro/pull/1162>)
- Fix hyperlink errors in the document
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this right place to log changes for 1.5.1?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so.

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinnamkim vinnamkim merged commit 9ecfe42 into openvinotoolkit:releases/1.5.0 Oct 16, 2023
6 checks passed
yunchu pushed a commit to yunchu/datumaro that referenced this pull request Oct 23, 2023
- Apply fixes to 1.5.1 from openvinotoolkit#1159 and openvinotoolkit#1161

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Co-authored-by: Matěj Šmíd <m@matejsmid.cz>
Co-authored-by: Daniil Pastukhov <plus79222222238@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working DOC Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants