Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix errata in the voc document #1162

Closed

Conversation

jihyeonyi
Copy link
Contributor

@jihyeonyi jihyeonyi commented Oct 5, 2023

Summary

Color values in the labelmap.txt should be separated by commas, not colons.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@jihyeonyi jihyeonyi marked this pull request as ready for review October 5, 2023 04:00
@jihyeonyi jihyeonyi requested review from a team as code owners October 5, 2023 04:00
@jihyeonyi jihyeonyi requested review from wonjuleee and removed request for a team October 5, 2023 04:00
@jihyeonyi jihyeonyi added the DOC Improvements or additions to documentation label Oct 5, 2023
@jihyeonyi jihyeonyi changed the base branch from develop to releases/1.5.0 October 5, 2023 04:09
@jihyeonyi jihyeonyi added this to the 1.5.1 milestone Oct 5, 2023
@jihyeonyi jihyeonyi marked this pull request as draft October 5, 2023 04:10
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (45958aa) 79.96% compared to head (5af04cb) 80.00%.

❗ Current head 5af04cb differs from pull request most recent head cd09e71. Consider uploading reports for the commit cd09e71 to get more accurate results

Additional details and impacted files
@@                Coverage Diff                 @@
##           releases/1.5.0    #1162      +/-   ##
==================================================
+ Coverage           79.96%   80.00%   +0.03%     
==================================================
  Files                 267      266       -1     
  Lines               29981    29967      -14     
  Branches             5898     5901       +3     
==================================================
  Hits                23975    23975              
+ Misses               4649     4633      -16     
- Partials             1357     1359       +2     
Flag Coverage Δ
macos-11_Python-3.8 79.13% <93.00%> (+0.04%) ⬆️
ubuntu-20.04_Python-3.8 80.00% <93.00%> (+0.04%) ⬆️
windows-2019_Python-3.8 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/datumaro/components/dataset.py 81.91% <ø> (ø)
src/datumaro/components/hl_ops/__init__.py 56.86% <ø> (ø)
src/datumaro/plugins/data_formats/coco/exporter.py 88.96% <100.00%> (+1.05%) ⬆️
...c/datumaro/plugins/missing_annotation_detection.py 100.00% <100.00%> (ø)
src/datumaro/util/multi_procs_util.py 97.87% <97.87%> (ø)
src/datumaro/components/transformer.py 90.52% <92.59%> (ø)
...tumaro/plugins/sam_transforms/bbox_to_inst_mask.py 85.71% <76.47%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yunchu and others added 7 commits October 5, 2023 13:16
* add ready_for_review status to the pr-test workflow triggering condition
<!-- Contributing guide:
https://github.com/openvinotoolkit/datumaro/blob/develop/CONTRIBUTING.md
-->

### Summary
Regarding Issue openvinotoolkit#1147 , modify coco exporter to be able to export
annotations even if there's no media.
Annotations which need media information will be skipped as same as
before.

<!--
Resolves openvinotoolkit#111 and openvinotoolkit#222.
Depends on openvinotoolkit#1000 (for series of dependent commits).

This PR introduces this capability to make the project better in this
and that.

- Added this feature
- Removed that feature
- Fixed the problem openvinotoolkit#1234
-->

### How to test
<!-- Describe the testing procedure for reviewers, if changes are
not fully covered by unit tests or manual testing can be complicated.
-->

### Checklist
<!-- Put an 'x' in all the boxes that apply -->
- [x] I have added unit tests to cover my changes.​
- [ ] I have added integration tests to cover my changes.​
- [x] I have added the description of my changes into
[CHANGELOG](https://github.com/openvinotoolkit/datumaro/blob/develop/CHANGELOG.md).​
- [ ] I have updated the
[documentation](https://github.com/openvinotoolkit/datumaro/tree/develop/docs)
accordingly

### License

- [x] I submit _my code changes_ under the same [MIT
License](https://github.com/openvinotoolkit/datumaro/blob/develop/LICENSE)
that covers the project.
  Feel free to contact the maintainers if that's a concern.
- [ ] I have updated the license header for each file (see an example
below).

```python
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT
```
fix link to transforms.py to match changed directory structure
- Fixed broken YOLO-ultralytics links that were referring to the format
specifications on GitHub. The source files were apparently changed, thus
links became invalid.
@jihyeonyi jihyeonyi closed this Oct 5, 2023
@vinnamkim vinnamkim mentioned this pull request Oct 6, 2023
6 tasks
@jihyeonyi jihyeonyi deleted the jihyeony/voc-errata branch January 8, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DOC Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants