Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify coco to export annotations without media #1158

Conversation

jihyeonyi
Copy link
Contributor

@jihyeonyi jihyeonyi commented Sep 25, 2023

Summary

Regarding Issue #1147 , modify coco exporter to be able to export annotations even if there's no media.
Annotations which need media information will be skipped as same as before.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@jihyeonyi jihyeonyi marked this pull request as ready for review September 25, 2023 03:06
@jihyeonyi jihyeonyi requested review from a team as code owners September 25, 2023 03:06
@jihyeonyi jihyeonyi requested review from wonjuleee and removed request for a team September 25, 2023 03:06
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (2180b04) 79.98% compared to head (cb486f7) 80.01%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1158      +/-   ##
===========================================
+ Coverage    79.98%   80.01%   +0.02%     
===========================================
  Files          266      266              
  Lines        29967    29967              
  Branches      5901     5901              
===========================================
+ Hits         23970    23978       +8     
+ Misses        4637     4632       -5     
+ Partials      1360     1357       -3     
Flag Coverage Δ
macos-11_Python-3.8 79.13% <100.00%> (+0.02%) ⬆️
ubuntu-20.04_Python-3.8 80.00% <100.00%> (+0.02%) ⬆️
windows-2019_Python-3.8 79.93% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/datumaro/plugins/data_formats/coco/exporter.py 88.96% <100.00%> (+1.05%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests/unit/test_coco_format.py Outdated Show resolved Hide resolved
tests/unit/test_coco_format.py Outdated Show resolved Hide resolved
tests/unit/test_coco_format.py Outdated Show resolved Hide resolved
tests/unit/test_coco_format.py Outdated Show resolved Hide resolved
@jihyeonyi jihyeonyi added this to the 1.6.0 milestone Sep 25, 2023
@jihyeonyi jihyeonyi added BUG Something isn't working data formats PR is related to dataset formats labels Sep 25, 2023
Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jihyeonyi jihyeonyi merged commit e03768b into openvinotoolkit:develop Sep 25, 2023
6 checks passed
@jihyeonyi jihyeonyi deleted the jihyeony/export_coco_from_datumaro_format_to_load_annotations branch September 25, 2023 23:54
@yunchu yunchu modified the milestones: 1.6.0, 2.0.0 Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working data formats PR is related to dataset formats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants