Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SAMBboxToInstanceMask transform #1133

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Aug 29, 2023

Summary

  • Ticket no. 116107
  • Add SAMBboxToInstanceMask transform
  • Revisit Docker image building for exporting decoder model to support batch prompt inputs
  • Refactor the model launcher to take a dictionary input not only the single image input.

How to test

Added unit tests for this change.

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim marked this pull request as ready for review August 29, 2023 06:26
@vinnamkim vinnamkim requested review from a team as code owners August 29, 2023 06:26
@vinnamkim vinnamkim requested review from sooahleex and removed request for a team August 29, 2023 06:26
@vinnamkim vinnamkim added this to the 1.5.0 milestone Aug 29, 2023
@vinnamkim vinnamkim added the ENHANCE Enhancement of existing features label Aug 29, 2023
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim force-pushed the feature/add-sam-bbox-to-polygon-transform branch from 6815c64 to 1376999 Compare August 29, 2023 06:43
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 81.25% and project coverage change: +0.05% 🎉

Comparison is base (7019fb7) 80.16% compared to head (1376999) 80.22%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1133      +/-   ##
===========================================
+ Coverage    80.16%   80.22%   +0.05%     
===========================================
  Files          260      264       +4     
  Lines        29370    29494     +124     
  Branches      5757     5779      +22     
===========================================
+ Hits         23545    23661     +116     
- Misses        4484     4487       +3     
- Partials      1341     1346       +5     
Flag Coverage Δ
macos-11_Python-3.8 79.31% <80.76%> (+0.05%) ⬆️
ubuntu-20.04_Python-3.8 80.20% <81.25%> (+0.05%) ⬆️
windows-2019_Python-3.8 80.13% <81.25%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/datumaro/components/annotation.py 90.31% <ø> (+0.26%) ⬆️
src/datumaro/plugins/specs.py 100.00% <ø> (ø)
.../datumaro/plugins/openvino_plugin/samples/utils.py 67.56% <40.00%> (+18.99%) ⬆️
src/datumaro/components/launcher.py 74.02% <50.00%> (-18.57%) ⬇️
...datumaro/plugins/inference_server_plugin/triton.py 69.64% <52.38%> (-10.80%) ⬇️
...envino_plugin/samples/clip_text_ViT-B_32_interp.py 70.00% <80.00%> (-2.23%) ⬇️
...es/otx_custom_object_detection_gen3_atss_interp.py 62.50% <80.00%> (-1.14%) ⬇️
...les/otx_custom_object_detection_gen3_ssd_interp.py 62.50% <80.00%> (-1.14%) ⬇️
...amples/otx_custom_object_detection_yolox_interp.py 62.50% <80.00%> (-1.14%) ⬇️
...tumaro/plugins/sam_transforms/bbox_to_inst_mask.py 94.11% <94.11%> (ø)
... and 12 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinnamkim vinnamkim merged commit 8ee3d03 into openvinotoolkit:develop Sep 6, 2023
4 checks passed
@vinnamkim vinnamkim deleted the feature/add-sam-bbox-to-polygon-transform branch September 6, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENHANCE Enhancement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants