Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notebook example for SAMBboxToInstanceMask transform #1134

Merged
merged 12 commits into from
Sep 6, 2023
Merged

Add notebook example for SAMBboxToInstanceMask transform #1134

merged 12 commits into from
Sep 6, 2023

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Aug 29, 2023 •
edited
Loading

Summary

  • Ticket no. 116107
  • Revisit Docker image again to support SAM vit_h model. This is because it exceeds 2GB, so that we need to fix torch.onnx.export() and managing the multiple generated model files (not single one onnx file which is generated when the model size is <2GB):
model.onnx          onnx__MatMul_12195                          sam.image_encoder.blocks.17.norm2.weight    sam.image_encoder.blocks.28.attn.rel_pos_w
onnx__MatMul_11300  onnx__MatMul_12204                          sam.image_encoder.blocks.18.attn.proj.bias  sam.image_encoder.blocks.28.mlp.lin1.bias
onnx__MatMul_11309  onnx__MatMul_12205                          sam.image_encoder.blocks.18.attn.qkv.bias   sam.image_encoder.blocks.28.mlp.lin2.bias
onnx__MatMul_11318  onnx__MatMul_12220                          sam.image_encoder.blocks.18.attn.rel_pos_h  sam.image_encoder.blocks.28.norm1.bias
onnx__MatMul_11319  onnx__MatMul_12229                          sam.image_encoder.blocks.18.attn.rel_pos_w  sam.image_encoder.blocks.28.norm1.weight
onnx__MatMul_11334  onnx__MatMul_12238                          sam.image_encoder.blocks.18.mlp.lin1.bias   sam.image_encoder.blocks.28.norm2.bias
onnx__MatMul_11343  onnx__MatMul_12239                          sam.image_encoder.blocks.18.mlp.lin2.bias   sam.image_encoder.blocks.28.norm2.weight
onnx__MatMul_11352  onnx__MatMul_12254                          sam.image_encoder.blocks.18.norm1.bias      sam.image_encoder.blocks.29.attn.proj.bias
onnx__MatMul_11353  onnx__MatMul_12263                          sam.image_encoder.blocks.18.norm1.weight    sam.image_encoder.blocks.29.attn.qkv.bias
onnx__MatMul_11368  onnx__MatMul_12272                          sam.image_encoder.blocks.18.norm2.bias      sam.image_encoder.blocks.29.attn.rel_pos_h
onnx__MatMul_11377  onnx__MatMul_12273                          sam.image_encoder.blocks.18.norm2.weight    sam.image_encoder.blocks.29.attn.rel_pos_w
onnx__MatMul_11386  onnx__MatMul_12274                          sam.image_encoder.blocks.19.attn.proj.bias  sam.image_encoder.blocks.29.mlp.lin1.bias
onnx__MatMul_11387  onnx__MatMul_12283                          sam.image_encoder.blocks.19.attn.qkv.bias   sam.image_encoder.blocks.29.mlp.lin2.bias
onnx__MatMul_11402  onnx__MatMul_12284                          sam.image_encoder.blocks.19.attn.rel_pos_h  sam.image_encoder.blocks.29.norm1.bias
onnx__MatMul_11411  onnx__MatMul_12285                          sam.image_encoder.blocks.19.attn.rel_pos_w  sam.image_encoder.blocks.29.norm1.weight
onnx__MatMul_11420  sam.image_encoder.blocks.0.attn.proj.bias   sam.image_encoder.blocks.19.mlp.lin1.bias   sam.image_encoder.blocks.29.norm2.bias
onnx__MatMul_11421  sam.image_encoder.blocks.0.attn.qkv.bias    sam.image_encoder.blocks.19.mlp.lin2.bias   sam.image_encoder.blocks.29.norm2.weight
onnx__MatMul_11436  sam.image_encoder.blocks.0.attn.rel_pos_h   sam.image_encoder.blocks.19.norm1.bias      sam.image_encoder.blocks.3.attn.proj.bias
onnx__MatMul_11445  sam.image_encoder.blocks.0.attn.rel_pos_w   sam.image_encoder.blocks.19.norm1.weight    sam.image_encoder.blocks.3.attn.qkv.bias
onnx__MatMul_11454  sam.image_encoder.blocks.0.mlp.lin1.bias    sam.image_encoder.blocks.19.norm2.bias      sam.image_encoder.blocks.3.attn.rel_pos_h
onnx__MatMul_11455  sam.image_encoder.blocks.0.mlp.lin2.bias    sam.image_encoder.blocks.19.norm2.weight    sam.image_encoder.blocks.3.attn.rel_pos_w
onnx__MatMul_11470  sam.image_encoder.blocks.0.norm1.bias       sam.image_encoder.blocks.2.attn.proj.bias   sam.image_encoder.blocks.3.mlp.lin1.bias
onnx__MatMul_11479  sam.image_encoder.blocks.0.norm1.weight     sam.image_encoder.blocks.2.attn.qkv.bias    sam.image_encoder.blocks.3.mlp.lin2.bias
onnx__MatMul_11488  sam.image_encoder.blocks.0.norm2.bias       sam.image_encoder.blocks.2.attn.rel_pos_h   sam.image_encoder.blocks.3.norm1.bias
onnx__MatMul_11489  sam.image_encoder.blocks.0.norm2.weight     sam.image_encoder.blocks.2.attn.rel_pos_w   sam.image_encoder.blocks.3.norm1.weight
onnx__MatMul_11504  sam.image_encoder.blocks.1.attn.proj.bias   sam.image_encoder.blocks.2.mlp.lin1.bias    sam.image_encoder.blocks.3.norm2.bias
onnx__MatMul_11513  sam.image_encoder.blocks.1.attn.qkv.bias    sam.image_encoder.blocks.2.mlp.lin2.bias    sam.image_encoder.blocks.3.norm2.weight
onnx__MatMul_11522  sam.image_encoder.blocks.1.attn.rel_pos_h   sam.image_encoder.blocks.2.norm1.bias       sam.image_encoder.blocks.30.attn.proj.bias
onnx__MatMul_11523  sam.image_encoder.blocks.1.attn.rel_pos_w   sam.image_encoder.blocks.2.norm1.weight     sam.image_encoder.blocks.30.attn.qkv.bias
onnx__MatMul_11524  sam.image_encoder.blocks.1.mlp.lin1.bias    sam.image_encoder.blocks.2.norm2.bias       sam.image_encoder.blocks.30.attn.rel_pos_h
onnx__MatMul_11533  sam.image_encoder.blocks.1.mlp.lin2.bias    sam.image_encoder.blocks.2.norm2.weight     sam.image_encoder.blocks.30.attn.rel_pos_w
onnx__MatMul_11534  sam.image_encoder.blocks.1.norm1.bias       sam.image_encoder.blocks.20.attn.proj.bias  sam.image_encoder.blocks.30.mlp.lin1.bias
onnx__MatMul_11535  sam.image_encoder.blocks.1.norm1.weight     sam.image_encoder.blocks.20.attn.qkv.bias   sam.image_encoder.blocks.30.mlp.lin2.bias
onnx__MatMul_11550  sam.image_encoder.blocks.1.norm2.bias       sam.image_encoder.blocks.20.attn.rel_pos_h  sam.image_encoder.blocks.30.norm1.bias
onnx__MatMul_11559  sam.image_encoder.blocks.1.norm2.weight     sam.image_encoder.blocks.20.attn.rel_pos_w  sam.image_encoder.blocks.30.norm1.weight
onnx__MatMul_11568  sam.image_encoder.blocks.10.attn.proj.bias  sam.image_encoder.blocks.20.mlp.lin1.bias   sam.image_encoder.blocks.30.norm2.bias
onnx__MatMul_11569  sam.image_encoder.blocks.10.attn.qkv.bias   sam.image_encoder.blocks.20.mlp.lin2.bias   sam.image_encoder.blocks.30.norm2.weight
onnx__MatMul_11584  sam.image_encoder.blocks.10.attn.rel_pos_h  sam.image_encoder.blocks.20.norm1.bias      sam.image_encoder.blocks.31.attn.proj.bias
onnx__MatMul_11593  sam.image_encoder.blocks.10.attn.rel_pos_w  sam.image_encoder.blocks.20.norm1.weight    sam.image_encoder.blocks.31.attn.qkv.bias
onnx__MatMul_11602  sam.image_encoder.blocks.10.mlp.lin1.bias   sam.image_encoder.blocks.20.norm2.bias      sam.image_encoder.blocks.31.attn.rel_pos_h
onnx__MatMul_11603  sam.image_encoder.blocks.10.mlp.lin2.bias   sam.image_encoder.blocks.20.norm2.weight    sam.image_encoder.blocks.31.attn.rel_pos_w
onnx__MatMul_11618  sam.image_encoder.blocks.10.norm1.bias      sam.image_encoder.blocks.21.attn.proj.bias  sam.image_encoder.blocks.31.mlp.lin1.bias
onnx__MatMul_11627  sam.image_encoder.blocks.10.norm1.weight    sam.image_encoder.blocks.21.attn.qkv.bias   sam.image_encoder.blocks.31.mlp.lin2.bias
onnx__MatMul_11636  sam.image_encoder.blocks.10.norm2.bias      sam.image_encoder.blocks.21.attn.rel_pos_h  sam.image_encoder.blocks.31.norm1.bias
onnx__MatMul_11637  sam.image_encoder.blocks.10.norm2.weight    sam.image_encoder.blocks.21.attn.rel_pos_w  sam.image_encoder.blocks.31.norm1.weight
onnx__MatMul_11652  sam.image_encoder.blocks.11.attn.proj.bias  sam.image_encoder.blocks.21.mlp.lin1.bias   sam.image_encoder.blocks.31.norm2.bias
onnx__MatMul_11661  sam.image_encoder.blocks.11.attn.qkv.bias   sam.image_encoder.blocks.21.mlp.lin2.bias   sam.image_encoder.blocks.31.norm2.weight
onnx__MatMul_11670  sam.image_encoder.blocks.11.attn.rel_pos_h  sam.image_encoder.blocks.21.norm1.bias      sam.image_encoder.blocks.4.attn.proj.bias
onnx__MatMul_11671  sam.image_encoder.blocks.11.attn.rel_pos_w  sam.image_encoder.blocks.21.norm1.weight    sam.image_encoder.blocks.4.attn.qkv.bias
onnx__MatMul_11686  sam.image_encoder.blocks.11.mlp.lin1.bias   sam.image_encoder.blocks.21.norm2.bias      sam.image_encoder.blocks.4.attn.rel_pos_h
onnx__MatMul_11695  sam.image_encoder.blocks.11.mlp.lin2.bias   sam.image_encoder.blocks.21.norm2.weight    sam.image_encoder.blocks.4.attn.rel_pos_w
onnx__MatMul_11704  sam.image_encoder.blocks.11.norm1.bias      sam.image_encoder.blocks.22.attn.proj.bias  sam.image_encoder.blocks.4.mlp.lin1.bias
onnx__MatMul_11705  sam.image_encoder.blocks.11.norm1.weight    sam.image_encoder.blocks.22.attn.qkv.bias   sam.image_encoder.blocks.4.mlp.lin2.bias
onnx__MatMul_11720  sam.image_encoder.blocks.11.norm2.bias      sam.image_encoder.blocks.22.attn.rel_pos_h  sam.image_encoder.blocks.4.norm1.bias
onnx__MatMul_11729  sam.image_encoder.blocks.11.norm2.weight    sam.image_encoder.blocks.22.attn.rel_pos_w  sam.image_encoder.blocks.4.norm1.weight
onnx__MatMul_11738  sam.image_encoder.blocks.12.attn.proj.bias  sam.image_encoder.blocks.22.mlp.lin1.bias   sam.image_encoder.blocks.4.norm2.bias
onnx__MatMul_11739  sam.image_encoder.blocks.12.attn.qkv.bias   sam.image_encoder.blocks.22.mlp.lin2.bias   sam.image_encoder.blocks.4.norm2.weight
onnx__MatMul_11754  sam.image_encoder.blocks.12.attn.rel_pos_h  sam.image_encoder.blocks.22.norm1.bias      sam.image_encoder.blocks.5.attn.proj.bias
onnx__MatMul_11763  sam.image_encoder.blocks.12.attn.rel_pos_w  sam.image_encoder.blocks.22.norm1.weight    sam.image_encoder.blocks.5.attn.qkv.bias
onnx__MatMul_11772  sam.image_encoder.blocks.12.mlp.lin1.bias   sam.image_encoder.blocks.22.norm2.bias      sam.image_encoder.blocks.5.attn.rel_pos_h
onnx__MatMul_11773  sam.image_encoder.blocks.12.mlp.lin2.bias   sam.image_encoder.blocks.22.norm2.weight    sam.image_encoder.blocks.5.attn.rel_pos_w
onnx__MatMul_11774  sam.image_encoder.blocks.12.norm1.bias      sam.image_encoder.blocks.23.attn.proj.bias  sam.image_encoder.blocks.5.mlp.lin1.bias
onnx__MatMul_11783  sam.image_encoder.blocks.12.norm1.weight    sam.image_encoder.blocks.23.attn.qkv.bias   sam.image_encoder.blocks.5.mlp.lin2.bias
onnx__MatMul_11784  sam.image_encoder.blocks.12.norm2.bias      sam.image_encoder.blocks.23.attn.rel_pos_h  sam.image_encoder.blocks.5.norm1.bias
onnx__MatMul_11785  sam.image_encoder.blocks.12.norm2.weight    sam.image_encoder.blocks.23.attn.rel_pos_w  sam.image_encoder.blocks.5.norm1.weight
onnx__MatMul_11800  sam.image_encoder.blocks.13.attn.proj.bias  sam.image_encoder.blocks.23.mlp.lin1.bias   sam.image_encoder.blocks.5.norm2.bias
onnx__MatMul_11809  sam.image_encoder.blocks.13.attn.qkv.bias   sam.image_encoder.blocks.23.mlp.lin2.bias   sam.image_encoder.blocks.5.norm2.weight
onnx__MatMul_11818  sam.image_encoder.blocks.13.attn.rel_pos_h  sam.image_encoder.blocks.23.norm1.bias      sam.image_encoder.blocks.6.attn.proj.bias
onnx__MatMul_11819  sam.image_encoder.blocks.13.attn.rel_pos_w  sam.image_encoder.blocks.23.norm1.weight    sam.image_encoder.blocks.6.attn.qkv.bias
onnx__MatMul_11834  sam.image_encoder.blocks.13.mlp.lin1.bias   sam.image_encoder.blocks.23.norm2.bias      sam.image_encoder.blocks.6.attn.rel_pos_h
onnx__MatMul_11843  sam.image_encoder.blocks.13.mlp.lin2.bias   sam.image_encoder.blocks.23.norm2.weight    sam.image_encoder.blocks.6.attn.rel_pos_w
onnx__MatMul_11852  sam.image_encoder.blocks.13.norm1.bias      sam.image_encoder.blocks.24.attn.proj.bias  sam.image_encoder.blocks.6.mlp.lin1.bias
onnx__MatMul_11853  sam.image_encoder.blocks.13.norm1.weight    sam.image_encoder.blocks.24.attn.qkv.bias   sam.image_encoder.blocks.6.mlp.lin2.bias
onnx__MatMul_11868  sam.image_encoder.blocks.13.norm2.bias      sam.image_encoder.blocks.24.attn.rel_pos_h  sam.image_encoder.blocks.6.norm1.bias
onnx__MatMul_11877  sam.image_encoder.blocks.13.norm2.weight    sam.image_encoder.blocks.24.attn.rel_pos_w  sam.image_encoder.blocks.6.norm1.weight
onnx__MatMul_11886  sam.image_encoder.blocks.14.attn.proj.bias  sam.image_encoder.blocks.24.mlp.lin1.bias   sam.image_encoder.blocks.6.norm2.bias
onnx__MatMul_11887  sam.image_encoder.blocks.14.attn.qkv.bias   sam.image_encoder.blocks.24.mlp.lin2.bias   sam.image_encoder.blocks.6.norm2.weight
onnx__MatMul_11902  sam.image_encoder.blocks.14.attn.rel_pos_h  sam.image_encoder.blocks.24.norm1.bias      sam.image_encoder.blocks.7.attn.proj.bias
onnx__MatMul_11911  sam.image_encoder.blocks.14.attn.rel_pos_w  sam.image_encoder.blocks.24.norm1.weight    sam.image_encoder.blocks.7.attn.qkv.bias
onnx__MatMul_11920  sam.image_encoder.blocks.14.mlp.lin1.bias   sam.image_encoder.blocks.24.norm2.bias      sam.image_encoder.blocks.7.attn.rel_pos_h
onnx__MatMul_11921  sam.image_encoder.blocks.14.mlp.lin2.bias   sam.image_encoder.blocks.24.norm2.weight    sam.image_encoder.blocks.7.attn.rel_pos_w
onnx__MatMul_11936  sam.image_encoder.blocks.14.norm1.bias      sam.image_encoder.blocks.25.attn.proj.bias  sam.image_encoder.blocks.7.mlp.lin1.bias
onnx__MatMul_11945  sam.image_encoder.blocks.14.norm1.weight    sam.image_encoder.blocks.25.attn.qkv.bias   sam.image_encoder.blocks.7.mlp.lin2.bias
onnx__MatMul_11954  sam.image_encoder.blocks.14.norm2.bias      sam.image_encoder.blocks.25.attn.rel_pos_h  sam.image_encoder.blocks.7.norm1.bias
onnx__MatMul_11955  sam.image_encoder.blocks.14.norm2.weight    sam.image_encoder.blocks.25.attn.rel_pos_w  sam.image_encoder.blocks.7.norm1.weight
onnx__MatMul_11970  sam.image_encoder.blocks.15.attn.proj.bias  sam.image_encoder.blocks.25.mlp.lin1.bias   sam.image_encoder.blocks.7.norm2.bias
onnx__MatMul_11979  sam.image_encoder.blocks.15.attn.qkv.bias   sam.image_encoder.blocks.25.mlp.lin2.bias   sam.image_encoder.blocks.7.norm2.weight
onnx__MatMul_11988  sam.image_encoder.blocks.15.attn.rel_pos_h  sam.image_encoder.blocks.25.norm1.bias      sam.image_encoder.blocks.8.attn.proj.bias
onnx__MatMul_11989  sam.image_encoder.blocks.15.attn.rel_pos_w  sam.image_encoder.blocks.25.norm1.weight    sam.image_encoder.blocks.8.attn.qkv.bias
onnx__MatMul_12004  sam.image_encoder.blocks.15.mlp.lin1.bias   sam.image_encoder.blocks.25.norm2.bias      sam.image_encoder.blocks.8.attn.rel_pos_h
onnx__MatMul_12013  sam.image_encoder.blocks.15.mlp.lin2.bias   sam.image_encoder.blocks.25.norm2.weight    sam.image_encoder.blocks.8.attn.rel_pos_w
onnx__MatMul_12022  sam.image_encoder.blocks.15.norm1.bias      sam.image_encoder.blocks.26.attn.proj.bias  sam.image_encoder.blocks.8.mlp.lin1.bias
onnx__MatMul_12023  sam.image_encoder.blocks.15.norm1.weight    sam.image_encoder.blocks.26.attn.qkv.bias   sam.image_encoder.blocks.8.mlp.lin2.bias
onnx__MatMul_12024  sam.image_encoder.blocks.15.norm2.bias      sam.image_encoder.blocks.26.attn.rel_pos_h  sam.image_encoder.blocks.8.norm1.bias
onnx__MatMul_12033  sam.image_encoder.blocks.15.norm2.weight    sam.image_encoder.blocks.26.attn.rel_pos_w  sam.image_encoder.blocks.8.norm1.weight
onnx__MatMul_12034  sam.image_encoder.blocks.16.attn.proj.bias  sam.image_encoder.blocks.26.mlp.lin1.bias   sam.image_encoder.blocks.8.norm2.bias
onnx__MatMul_12035  sam.image_encoder.blocks.16.attn.qkv.bias   sam.image_encoder.blocks.26.mlp.lin2.bias   sam.image_encoder.blocks.8.norm2.weight
onnx__MatMul_12050  sam.image_encoder.blocks.16.attn.rel_pos_h  sam.image_encoder.blocks.26.norm1.bias      sam.image_encoder.blocks.9.attn.proj.bias
onnx__MatMul_12059  sam.image_encoder.blocks.16.attn.rel_pos_w  sam.image_encoder.blocks.26.norm1.weight    sam.image_encoder.blocks.9.attn.qkv.bias
onnx__MatMul_12068  sam.image_encoder.blocks.16.mlp.lin1.bias   sam.image_encoder.blocks.26.norm2.bias      sam.image_encoder.blocks.9.attn.rel_pos_h
onnx__MatMul_12069  sam.image_encoder.blocks.16.mlp.lin2.bias   sam.image_encoder.blocks.26.norm2.weight    sam.image_encoder.blocks.9.attn.rel_pos_w
onnx__MatMul_12084  sam.image_encoder.blocks.16.norm1.bias      sam.image_encoder.blocks.27.attn.proj.bias  sam.image_encoder.blocks.9.mlp.lin1.bias
onnx__MatMul_12093  sam.image_encoder.blocks.16.norm1.weight    sam.image_encoder.blocks.27.attn.qkv.bias   sam.image_encoder.blocks.9.mlp.lin2.bias
onnx__MatMul_12102  sam.image_encoder.blocks.16.norm2.bias      sam.image_encoder.blocks.27.attn.rel_pos_h  sam.image_encoder.blocks.9.norm1.bias
onnx__MatMul_12103  sam.image_encoder.blocks.16.norm2.weight    sam.image_encoder.blocks.27.attn.rel_pos_w  sam.image_encoder.blocks.9.norm1.weight
onnx__MatMul_12118  sam.image_encoder.blocks.17.attn.proj.bias  sam.image_encoder.blocks.27.mlp.lin1.bias   sam.image_encoder.blocks.9.norm2.bias
onnx__MatMul_12127  sam.image_encoder.blocks.17.attn.qkv.bias   sam.image_encoder.blocks.27.mlp.lin2.bias   sam.image_encoder.blocks.9.norm2.weight
onnx__MatMul_12136  sam.image_encoder.blocks.17.attn.rel_pos_h  sam.image_encoder.blocks.27.norm1.bias      sam.image_encoder.neck.0.weight
onnx__MatMul_12137  sam.image_encoder.blocks.17.attn.rel_pos_w  sam.image_encoder.blocks.27.norm1.weight    sam.image_encoder.neck.2.weight
onnx__MatMul_12152  sam.image_encoder.blocks.17.mlp.lin1.bias   sam.image_encoder.blocks.27.norm2.bias      sam.image_encoder.patch_embed.proj.bias
onnx__MatMul_12161  sam.image_encoder.blocks.17.mlp.lin2.bias   sam.image_encoder.blocks.27.norm2.weight    sam.image_encoder.patch_embed.proj.weight
onnx__MatMul_12170  sam.image_encoder.blocks.17.norm1.bias      sam.image_encoder.blocks.28.attn.proj.bias  sam.image_encoder.pos_embed
onnx__MatMul_12171  sam.image_encoder.blocks.17.norm1.weight    sam.image_encoder.blocks.28.attn.qkv.bias
onnx__MatMul_12186  sam.image_encoder.blocks.17.norm2.bias      sam.image_encoder.blocks.28.attn.rel_pos_h

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@vinnamkim
Refactor Launcher and ModelInterpreter to take DatasetItem input
166b06f 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Add SAMBboxToInstanceMask
9d98a6e 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Fix README.md
8edeced 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Update CHANGELOG.md
f0fe681 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Update specs.json
1376999 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Add 18_bbox_to_instance_mask_using_sam.ipynb
453ab0d 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Update docs for the added notebook example
6866bfd 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@vinnamkim
Copy link
Contributor Author

Please review after #1133

@vinnamkim
Update CHANGELOG.md
fb964e6 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Remove unused imports
328de0a 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim added this to the 1.5.0 milestone Sep 6, 2023
@vinnamkim vinnamkim added DOC Improvements or additions to documentation FEATURE New feature & functionality labels Sep 6, 2023
@vinnamkim vinnamkim marked this pull request as ready for review September 6, 2023 06:13
@vinnamkim vinnamkim requested review from a team as code owners September 6, 2023 06:13
@vinnamkim vinnamkim requested review from jihyeonyi and removed request for a team September 6, 2023 06:13
@vinnamkim
Merge remote-tracking branch 'origin/develop' into docs/add-example-f…
5803d94 
…or-sam-bbox-to-inst-mask
@vinnamkim
Merge remote-tracking branch 'upstream/develop' into docs/add-example…
5b691b4 
…-for-sam-bbox-to-inst-mask

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Revert unwanted change
d47fca3 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@codecov
Copy link

codecov bot commented Sep 6, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8ee3d03) 79.86% compared to head (d47fca3) 79.86%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1134   +/-   ##
========================================
  Coverage    79.86%   79.86%           
========================================
  Files          264      264           
  Lines        29390    29391    +1     
  Branches      5753     5753           
========================================
+ Hits         23473    23474    +1     
  Misses        4582     4582           
  Partials      1335     1335
Flag Coverage Δ
macos-11_Python-3.8 78.96% <100.00%> (-0.01%) ⬇️
ubuntu-20.04_Python-3.8 79.85% <100.00%> (+<0.01%) ⬆️
windows-2019_Python-3.8 79.78% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...tumaro/plugins/inference_server_plugin/__init__.py 100.00% <100.00%> (ø)
...tumaro/plugins/sam_transforms/bbox_to_inst_mask.py 94.28% <100.00%> (+0.16%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

wonjuleee
wonjuleee approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinnamkim vinnamkim merged commit ec00525 into openvinotoolkit:develop Sep 6, 2023
7 checks passed
@vinnamkim vinnamkim deleted the docs/add-example-for-sam-bbox-to-inst-mask branch September 6, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jihyeonyi jihyeonyi jihyeonyi approved these changes

@wonjuleee wonjuleee wonjuleee approved these changes

Assignees
No one assigned
Labels
DOC Improvements or additions to documentation FEATURE New feature & functionality
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@vinnamkim @jihyeonyi @wonjuleee