Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial docs string #9

Merged
merged 3 commits into from
Nov 29, 2021
Merged

Initial docs string #9

merged 3 commits into from
Nov 29, 2021

Conversation

ashwinvaidya17
Copy link
Collaborator

Changes

  • Address docstring issues reported by pydocstyle.
  • Add pydocstyle to tox.ini
  • Add pydocstyle to .pre-commit.yml

samet-akcay
samet-akcay approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will probably cause some conflicts in my PR, but let's get this one merged first.

@samet-akcay
Copy link
Contributor

@djdameln you don't need to review this since almost all of the files are related to docstring formatting. I'll be merging this one to deal with the conflicts that it will cause on my PR #8

@samet-akcay samet-akcay merged commit 6088790 into development Nov 29, 2021
@samet-akcay samet-akcay deleted the refactor/ashwin/fix_docstrings branch November 29, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samet-akcay samet-akcay samet-akcay approved these changes

@djdameln djdameln Awaiting requested review from djdameln

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ashwinvaidya17 @samet-akcay