Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/samet/data #8

Merged
merged 47 commits into from
Nov 30, 2021
Merged

Refactor/samet/data #8

merged 47 commits into from
Nov 30, 2021

Conversation

samet-akcay
Copy link
Contributor

Changes

  • Apply pydocstyle to the changes.
  • Refactor anomalib.dataset into anomalib.data
  • Remove anomalib.data.anomaly_dataset
  • Refactor anomalib.data.mvtec to use it as the default dataset

Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

anomalib/data/__init__.py Outdated Show resolved Hide resolved
anomalib/data/mvtec.py Outdated Show resolved Hide resolved
@djdameln
Copy link
Contributor

Thanks. My only comment is about the download functionality. Now that we are using the MVTec class for other datasets that follow the MVTec directory structure, it might be better to separate the _download and _extract methods from the class. Users should be able to write their own implementations of these methods, so we could maybe add an interface (e.g. MVTecStyle(VisionDataset)) and n implementation specific for the actual MVTec dataset (e.g. MVTec(MVTecStyle)). But like I said in the comments we could do address this in a separate PR.

@samet-akcay samet-akcay mentioned this pull request Nov 29, 2021
@samet-akcay samet-akcay merged commit 58393a7 into development Nov 30, 2021
@samet-akcay samet-akcay deleted the refactor/samet/data branch December 2, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants