Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 CI: Nightly Build #66

Merged
merged 18 commits into from
Feb 7, 2022
Merged

🚀 CI: Nightly Build #66

merged 18 commits into from
Feb 7, 2022

Conversation

ashwinvaidya17
Copy link
Collaborator

Changes

🚀 Add nightly build to CI
🚚 Move PR template to .github root

source /home/ashwin/miniconda3/bin/activate# This is a combination of…
b912fd6 
… 2 commits. conda activate anomalib# This is the 1st commit message:

🚀 Add nightly build to CI
🚚 Move PR template to .github root
samet-akcay
samet-akcay reviewed Jan 25, 2022
View reviewed changes
anomalib/core/metrics/auroc.py Outdated Show resolved Hide resolved
tests/helpers/model.py Outdated Show resolved Hide resolved
tests/nightly/models/test_model_nightly.py Outdated Show resolved Hide resolved
@ashwinvaidya17
Copy link
Collaborator Author

Adding todo here for later reference.

  • Parallelize runs over multiple GPUs

@ashwinvaidya17 ashwinvaidya17 marked this pull request as draft January 31, 2022 09:34
samet-akcay
samet-akcay reviewed Feb 1, 2022
View reviewed changes
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What an improvement! Thanks a lot for organising this mess! Only minor comments...

tests/nightly/core/callbacks/compress_callback/test_compress.py Outdated Show resolved Hide resolved
tests/nightly/models/test_model_nightly.py Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
tests/nightly/models/test_model_nightly.py Show resolved Hide resolved
tests/pre_merge/models/test_model_premerge.py Show resolved Hide resolved
This was referenced Feb 2, 2022
Closed
Closed
@ashwinvaidya17 ashwinvaidya17 marked this pull request as ready for review February 2, 2022 10:32
@ashwinvaidya17 ashwinvaidya17 changed the title Draft: CI: Nightly Build 🚀 CI: Nightly Build Feb 2, 2022
@djdameln
Copy link
Contributor

djdameln commented Feb 7, 2022

I feel that maybe the callback tests should be executed at pre-merge instead of nightly. We could run them on a dummy dataset so that it does not take a long time to run.

Ashwin Vaidya added 2 commits February 7, 2022 13:49
@samet-akcay samet-akcay merged commit 5f2dda2 into development Feb 7, 2022
@samet-akcay samet-akcay deleted the ci/ashwin/nightly_build branch February 7, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samet-akcay samet-akcay samet-akcay approved these changes

@djdameln djdameln Awaiting requested review from djdameln

Assignees
No one assigned
Labels
CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ashwinvaidya17 @djdameln @samet-akcay