Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧪 Increase test coverage for Pre-Merge and Nightly #94

Closed
ashwinvaidya17 opened this issue Feb 2, 2022 · 0 comments
Closed

🧪 Increase test coverage for Pre-Merge and Nightly #94

ashwinvaidya17 opened this issue Feb 2, 2022 · 0 comments
Labels
CI Enhancement New feature or request
Milestone
Backlog

Comments

@ashwinvaidya17
Copy link
Collaborator

ashwinvaidya17 commented Feb 2, 2022 •
edited by samet-akcay
Loading

PR #66 splits the tests to nightly and pre-merge. The coverage threshold has been reduced to 71% and 88% for nightly and pre-merge jobs, respectively. It should be brought the coverage back to 90%+.
@ashwinvaidya17 ashwinvaidya17 mentioned this issue Feb 2, 2022
Merged
@ashwinvaidya17 ashwinvaidya17 changed the title 🧪 Increase test coverage for Pre-merge 🧪 Increase test coverage for Nightly Feb 7, 2022
ashwinvaidya17 pushed a commit that referenced this issue Feb 7, 2022
🚚 Move callback tests to pre-merge
acd1c7c 
Change tox.ini to reflect new coverage threshold. Ref issue #94
samet-akcay pushed a commit that referenced this issue Feb 7, 2022
@ashwinvaidya17
🚀 CI: Nightly Build (#66)
5f2dda2 
🚀 Add nightly build to CI
🚚 Move PR template to .github root
🚀 Fix syntax

* 🔨 Refactor model train tests into pre-merge and nightly.

* 🩹 Fix file name issue for pytest and add init

* 🚚 Move core tests to nightly

* 🔨 fix import

* Add nightly to tox and remove os.environ

* Update thresholds

* Fix isort issues

* Fix isort issues

* 🚚 move tests/nightly/core to tests/nightly/utils

* 🚚 Move callback tests to pre-merge
Change tox.ini to reflect new coverage threshold. Ref issue #94

* Rename setup in test helpers

* 🩹 Fix tests

Co-authored-by: Ashwin Vaidya <ashwinitinvaidya@gmail.com>
@samet-akcay samet-akcay changed the title 🧪 Increase test coverage for Nightly 🧪 Increase test coverage for Pre-Merge and Nightly Feb 8, 2022
@samet-akcay samet-akcay added the Enhancement New feature or request label Apr 1, 2022
@samet-akcay samet-akcay added this to the Backlog milestone Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Enhancement New feature or request
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@ashwinvaidya17 @samet-akcay