Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anomalib CLI Improvements - Update metrics and create post_processing section in the config file #607

Merged
merged 11 commits into from
Oct 17, 2022

Conversation

samet-akcay
Copy link
Contributor

Description

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Maybe later we can look into setting up these values without using a callback.

anomalib/utils/callbacks/post_processing_configuration.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added the HPO label Oct 3, 2022
Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe later we can look into setting up these values without using a callback.

Yeah. I'm a bit concerned about adding too many ConfigurationCallbacks, because I feel this is not in line with the intended use of PL's Callback class. But at this point I also don't have a better design in mind that would work with the CLI. So for now we could keep it this way.

adaptive_threshold or default_image_threshold is not None and default_pixel_threshold is not None
), "Default thresholds must be specified when adaptive threshold is disabled."

self.adaptive_threshold = adaptive_threshold
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could consider replacing this parameter with a selectable called thresholding_method with the options fixed and adaptive. This might be a bit less confusing (for the unknowing reader, adaptive_threshold could sound like it holds a threshold value). Later we could extend it with synthetic option.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was also having a similar idea in my mind. I was not quite sure how exactly to address fixed image and pixel thresholds though

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be the equivalent of adaptive_threshold: false in the current implementation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, but let's say we set thresholding_method to fixed. We would still need to set fixed_image_threshold and fixed_pixel_threshold, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, but I don't see any problems with that. If users want to use a fixed threshold then they will have to provide a value for that. If they don't know which value to provide then they should just use the adaptive threshold.

@samet-akcay
Copy link
Contributor Author

Yeah. I'm a bit concerned about adding too many ConfigurationCallbacks, because I feel this is not in line with the intended use of PL's Callback class. But at this point I also don't have a better design in mind that would work with the CLI. So for now we could keep it this way.

This is the phase-2 of this cli refactoring. It requires some additional extensions to the lightning cli

@samet-akcay samet-akcay merged commit 1ba8d12 into main Oct 17, 2022
@samet-akcay samet-akcay deleted the cli/sa/create-post-processing-section-in-configs branch October 17, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anomalib CLI Improvements - Update metrics and create post_processing section in the config file.
3 participants