Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anomalib CLI Improvements - Update metrics and create post_processing section in the config file. #384

Closed
3 tasks
samet-akcay opened this issue Jun 23, 2022 · 1 comment · Fixed by #607
Closed
3 tasks
Assignees
Labels
Config Refactor Refactoring is needed

Comments

@samet-akcay
Copy link
Contributor

samet-akcay commented Jun 23, 2022

The new Anomalib CLI has threshold and normalization_method parameters in the metrics section. However, this may not be intuitive. Instead, it would be better to create a post_processing to store these parameters.

In addition, image_metric_names and pixel_metric_names are a bit verbose, especially for the API version. Instead, those could be renamed as image_metrics and pixel_metrics, respectively.

Overall, the updated config file would be something like:

.
.
.
metrics:
  image_metrics:
    - F1Score
    - AUROC
  pixel_metrics:
    - F1Score
    - AUROC

post_processing:
  adaptive_threshold: true
  default_image_threshold: null
  default_pixel_threshold: null
  normalization_method: min_max

visualization:
  task: segmentation
  log_images_to:
    - local
  inputs_are_normalized: true
.
.
.
  • Update the metrics_names parameters
  • Assign default values to metrics_names
  • Move threshold and normalization_method parameters to post_processing section.
@samet-akcay samet-akcay added Refactor Refactoring is needed Config labels Jun 24, 2022
@cyj95
Copy link

cyj95 commented Jul 1, 2022

where are metrics calculated? in which python file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Config Refactor Refactoring is needed
Projects
None yet
2 participants