Minor refactor #587
Merged
Minor refactor #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix patchcore image-level score computation * docstring and comment * remove default value for n_neighbors * torch.Tensor -> Tensor
samet-akcay
approved these changes
Sep 26, 2022
There was a problem hiding this comment.
Thanks. Would it be possible to make this change to #576 ? Otherwise, we'll need to update it too?
|
@samet-akcay I've changed the target but the |
samet-akcay
added a commit
that referenced
this pull request
Sep 27, 2022
* Add benchmark to tutorial * Move export to tutorials * Move hpo to tutorials * Move inference to tutorials * Move logging to tutorials * Create installation in tutorials * Create training to tutorials * Create tutorials index * Update conf.py file * Add anomalib logos to logos directory * Add data docs * Add algos * Add model docs * Add reference api * Remove blank line in metrics * Add reference guide * Add how to guides * Add developer guide * Add blog to how-to-guide * Remove guides directory * Add train custom data to how-to-guides * Fix typos * Add notebooks to how-to-guides * Add anomalib favicon * Add missing algo descriptions * Rename Reference to Reference Guide * Add how to add a new model * fix typos * Merge PR 544 * Minor refactor (#587) * 🛠 Fix PatchCore image-level score computation (#580) * fix patchcore image-level score computation * docstring and comment * remove default value for n_neighbors * torch.Tensor -> Tensor * Minor refactor Co-authored-by: Dick Ameln <dick.ameln@intel.com> Co-authored-by: Ashwin Vaidya <ashwinitinvaidya@gmail.com> * Address Dicks comments Co-authored-by: Ashwin Vaidya <ashwin.vaidya@intel.com> Co-authored-by: Dick Ameln <dick.ameln@intel.com> Co-authored-by: Ashwin Vaidya <ashwinitinvaidya@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description