Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation refactor #576

Merged
merged 33 commits into from
Sep 27, 2022
Merged

Documentation refactor #576

merged 33 commits into from
Sep 27, 2022

Conversation

samet-akcay
Copy link
Contributor

@samet-akcay samet-akcay commented Sep 23, 2022 •
edited
Loading

Description

image

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added Data Dependencies Pull requests that update a dependency file Docs Notebooks labels Sep 23, 2022
@samet-akcay samet-akcay marked this pull request as ready for review September 23, 2022 06:15
@jpcbertoldo
Copy link
Contributor

maybe #544 could be integrated here?
(tbh i didnt read it all so if it's already in there just ignore the comment)

ashwinvaidya17
ashwinvaidya17 approved these changes Sep 23, 2022
View reviewed changes
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the efforts!

@jpcbertoldo jpcbertoldo mentioned this pull request Sep 26, 2022
Closed
14 tasks
@ashwinvaidya17 @djdameln
Minor refactor (#587)
6b5f262 
* 🛠 Fix PatchCore image-level score computation (#580)

* fix patchcore image-level score computation

* docstring and comment

* remove default value for n_neighbors

* torch.Tensor -> Tensor

* Minor refactor

Co-authored-by: Dick Ameln <dick.ameln@intel.com>
Co-authored-by: Ashwin Vaidya <ashwinitinvaidya@gmail.com>
djdameln
djdameln requested changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

docs/source/how_to_guides/adding_a_new_model.rst Outdated Show resolved Hide resolved
docs/source/how_to_guides/adding_a_new_model.rst Outdated Show resolved Hide resolved
docs/source/how_to_guides/adding_a_new_model.rst Outdated Show resolved Hide resolved
docs/source/how_to_guides/adding_a_new_model.rst Outdated Show resolved Hide resolved
docs/source/how_to_guides/adding_a_new_model.rst Outdated Show resolved Hide resolved
@samet-akcay
Copy link
Contributor Author

Minor comments

@djdameln, thanks for the review. I've addressed all of your comments.

djdameln
djdameln approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@samet-akcay samet-akcay merged commit 598673a into main Sep 27, 2022
@samet-akcay samet-akcay deleted the documentation-refactor branch September 27, 2022 12:30
This was referenced Sep 27, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwinvaidya17 ashwinvaidya17 ashwinvaidya17 approved these changes

@djdameln djdameln djdameln approved these changes

Assignees
No one assigned
Labels
Data Dependencies Pull requests that update a dependency file HPO Notebooks Tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update sphinx document for all the new models
4 participants
@samet-akcay @jpcbertoldo @ashwinvaidya17 @djdameln