Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dockerfile #478

Merged
merged 5 commits into from
Aug 3, 2022
Merged

Fix Dockerfile #478

merged 5 commits into from
Aug 3, 2022

Conversation

ORippler
Copy link
Contributor

@ORippler ORippler commented Aug 2, 2022

Description

  • Provide a summary of the modification as well as the issue that has been resolved. List any dependencies that this modification necessitates.
  1. Install nodejs npm ruby (first two required by prettier hook, last one required by markdownlint)
  2. Readd ./requirements/dev.txt with appropriate packages needed for development and used by vs code via .devconatiner/devcontainer.json

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

1. Install `nodejs npm ruby` (first two required by prettier hook,
last one required by markdownlint)
2. Readd `./requirements/dev.txt` with appropriate packages needed for
development
@samet-akcay
Copy link
Contributor

@ORippler thanks for updating the docker file, which was not up-to-date. The reason for removing dev.txt is because we wanted to rely on pre-commit settings even when running tox. This was to avoid discrepancy between tox runs and pre-commit runs. This change also reduced the CI code-quality checks from 8mins to 2 mins.

requirements/dev.txt Outdated Show resolved Hide resolved
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this!

@samet-akcay
Copy link
Contributor

@ORippler will you be able to rebase your branch using the latest main? There were some breaking changes in PyTorch Lightning v1.7

@samet-akcay samet-akcay merged commit 6dfb283 into openvinotoolkit:main Aug 3, 2022
@ORippler ORippler deleted the fix_docker branch August 4, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerfile does not contain all tools needed to develop anomalib
3 participants