Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile does not contain all tools needed to develop anomalib #477

Closed
ORippler opened this issue Aug 2, 2022 · 0 comments · Fixed by #478
Closed

Dockerfile does not contain all tools needed to develop anomalib #477

ORippler opened this issue Aug 2, 2022 · 0 comments · Fixed by #478

Comments

@ORippler
Copy link
Contributor

ORippler commented Aug 2, 2022 •
edited
Loading

Describe the bug

  1. Dockerfile doesn't build since ./requirements/dev.txt was deleted/removed.
  2. Pre-commit hooks that rely on nodejs npm or ruby fail, since they use the system install
  3. Due to removal of black, flake and others, functionality such as format_on_save specified in .devcontainer.devcontainer.json no longer works.

To Reproduce

  1. Build docker container
  2. Run the pre-commit hooks

Expected behavior

Dockerfile works
@ORippler ORippler mentioned this issue Aug 2, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Dockerfile
1 participant
@ORippler